From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 708A5C433E1 for ; Fri, 5 Jun 2020 21:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 451BD206E6 for ; Fri, 5 Jun 2020 21:36:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="j58jeBpR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728314AbgFEVgZ (ORCPT ); Fri, 5 Jun 2020 17:36:25 -0400 Received: from linux.microsoft.com ([13.77.154.182]:37904 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728196AbgFEVgY (ORCPT ); Fri, 5 Jun 2020 17:36:24 -0400 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id B08E720B7185; Fri, 5 Jun 2020 14:36:23 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B08E720B7185 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1591392984; bh=tSnjZ9WzP0jd/9ONy9pB1uG8pmrZd7Nd6pMK3U8G3C4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=j58jeBpR0kcXUseKBLySEsy/s0CJ1AEVdtyeq8dwUJfDag8iMV00cQQpuKNVK3hWm gqDAM1S60XXnP0C/nlk2mYm1BlE/kJkm3jqgUIiro1n3zvsDwjcORxRMRRlHnmqPcX Tq54+lS9SoIkglIxBY6Jj+W+/XqXZBleQ5iMo1cM= Subject: Re: [PATCH] IMA: Add log statements for failure conditions To: Mimi Zohar , Paul Moore Cc: linux-integrity@vger.kernel.org, tusharsu@linux.microsoft.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com References: <20200604163243.2575-1-nramas@linux.microsoft.com> <1591382782.5816.36.camel@linux.ibm.com> <8dfb3fa6-5c1f-d644-7d21-72a9448c52cc@linux.microsoft.com> <48ff60f1-df93-5ce7-a254-8bfd1dba2ade@linux.microsoft.com> <1591392867.4615.20.camel@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: <755741f8-7f55-e40d-bb05-c05be2e02e9e@linux.microsoft.com> Date: Fri, 5 Jun 2020 14:36:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <1591392867.4615.20.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/20 2:34 PM, Mimi Zohar wrote: >> >> Maybe I can use the audit_msgno "AUDIT_INTEGRITY_PCR" with appropriate >> strings for "op" and "cause". >> >> Mimi - please let me know if you think this audit_msgno would be ok to >> use. I see this code used, for instance, for boot aggregate measurement. >> >> integrity_audit_msg(AUDIT_INTEGRITY_PCR, NULL, boot_aggregate_name, op, >> audit_cause, result, 0); > > Yes, AUDIT_INTEGRITY_PCR is also used for failures to add to the > measurement list. > thanks - i'll post an updated patch shortly. -lakshmi