Re: [PATCH] IMA: Add log statements for failure conditions

Lakshmi Ramasubramanian
2020-06-05T19:54:17Z

On 6/5/20 12:37 PM, Paul Moore wrote:

> If it's audit related, it's generally best to CC the linux-audit list,
> not just me (fixed).
>
> It's not clear to me what this pr_err() is trying to indicate other
> than *something* failed. Can someone provide some more background on
> this message?

process_buffer_measurement() is currently used to measure
"kexec command line", "keys", and "blacklist-hash". If there was any
error in the measurement, this pr_err() will indicate which of the above
measurement failed and the related error code.

Please let me know if you need more info on this one.

Since a pr_xyz() call was already present, I just wanted to change the
log level to keep the code change to the minimum. But if audit log is
the right approach for this case, I'll update.

thanks,
-lakshmi