From: Oliver Neukum <oneukum@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Josh Boyer <jwboyer@redhat.com>,
gregkh@linuxfoundation.org, mdharm-usb@one-eyed-alien.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: USB autosuspend vs. URB submission
Date: Thu, 10 Jan 2013 16:37:06 +0100 [thread overview]
Message-ID: <7574048.Em7ePkbmsJ@linux-5eaq.site> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1301101015530.1178-100000@iolanthe.rowland.org>
On Thursday 10 January 2013 10:20:42 Alan Stern wrote:
> On Thu, 10 Jan 2013, Oliver Neukum wrote:
> > In the long run it is probably a good idea to pass duplicated URBs to usbmon by
> > a special code path.
>
> I'd prefer to add extra information to the WARN_ONCE message. Even
> though it would require the extra effort of correlating the dmesg
> output with the usbmon output.
A stack_trace() I presume.
But what is the use of needing two logs?
> You know, it's possible that the URB really was not submitted before
> but instead the urb->hcpriv field got overwritten. Of course, that
> would also be a bug.
We could log a corrupted URB generically speaking.
Regards
Oliver
next prev parent reply other threads:[~2013-01-10 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 20:42 USB autosuspend vs. URB submission Josh Boyer
2013-01-08 15:51 ` Alan Stern
2013-01-08 16:03 ` Josh Boyer
2013-01-09 23:05 ` Laurent Pinchart
2013-01-10 5:13 ` Ming Lei
2013-01-10 10:02 ` Oliver Neukum
2013-01-10 9:42 ` Oliver Neukum
2013-01-10 15:20 ` Alan Stern
2013-01-10 15:37 ` Oliver Neukum [this message]
2013-01-10 15:13 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7574048.Em7ePkbmsJ@linux-5eaq.site \
--to=oneukum@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jwboyer@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox