Re: [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc()

Markus Elfring
2020-05-08T13:44:22Z

> An error is found by a internel analysis tool:
> "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c

If such an information will ever be integrated into a final commit message,
I would prefer a wording variant like the following.

Two issues were pointed out by an internal source code analysis tool:
* Line …:
Memory leak: data

* Line …:
Resource leak: fd

Each of these issues has got a different importance for this function implementation.

> Fix the @data and @fd allocations that are leaked in the error path of
> apply_xbc().

How do you think about to replace the @ characters by other delimiters
for the relevant identifiers?

Regards,
Markus