From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbcBJTyA (ORCPT ); Wed, 10 Feb 2016 14:54:00 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:59004 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753103AbcBJTx6 (ORCPT ); Wed, 10 Feb 2016 14:53:58 -0500 From: Arnd Bergmann To: Matthias Brugger Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, Eddie Huang , Sascha Hauer , Paul Gortmaker , Matt Redfearn , Paul Burton , Jiri Slaby , linux-serial@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] serial: 8250: fix building mediatek with SERIAL_8250=m Date: Wed, 10 Feb 2016 20:52:11 +0100 Message-ID: <7590955.HIrRGSSVmH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56BB7C23.5070600@gmail.com> References: <1454935947-2743255-1-git-send-email-arnd@arndb.de> <56BB7C23.5070600@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:9nrduHDuozPfyKsf4JmHmehG1Ec7EaVdwlFd/6NJpVAEYGb+mxt Ce8WFGlapJIaSKeyTarHGXwU2pvl2nFaV5yDYf6s5hnw9wCC8/3fHd5SHLihbntXmgF5OcO Su0JLXPN0QhRRYyZeT9JloCS36R7+bwmus4OsFMwL9pfkVf8StZKBqIp1NoCPANgTIx3lSC 94BCXm8n1kXIVnF0g4cRQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:I6Q47PpkQX4=:X+GpaQTj9Vysolpe0GkdPb rMkKKOcA1CR32ZVb2aWB2V6zBnI2SEO2oJz3s2qtJjL+V2BS33TkIJcvy8SaBc+chXx3n5YEG pqZLyNmIkeYmbOdRUZxp3PCT5Vi4qv8slFy433C01BKs2jOM5CImXzNYnYJhSqUIM0cuKoym6 3NcOUfS1NoHal7CWc+lKgD99FC6J1IEbwJn0ECjdPZS0Bbdw2SAp/axnz5dE2OjX1gOJZAahM DJVV0bq0jHKaqWYcBkHhPkEsP5ayD0D8e5IrS6ojng0ll91affMPk02dhKrtEOgKUYLv0ry+j 8m7ycm69StdztkUkBgMm0C/zUZHaEz3uzQ0j+eveBV/SAYG0TegxooHQtVRBjLYh6c4uPOUQ+ hFn0qNzORjFVd7mgYAkyDeCCIZ92UO4x6A0dnLW40gfX4Il76Bmt11inVvxbwxC0QTxOmZFyh uwhcBeQnZzvXobm3Fz4LXsegbZa9PHuI615JehkWPrZEsXJ3vYeGh+Fzh05q1tmxhOCQAd1Rm GVxs/86GZcGfUItwE3slF6RjdrUIBZ3L3uFvcTgau9JPhpRYuT7TMLdiB7Gy6/EmD+0SLcwI8 h5x77TfPR+MhRn66Rt3ipfNSy6Q82qp3RB/ii8ZA/NB9UytbhnzV+QU+a0DmbqpffiDpHixQf DOgqQqqKschEyXpWwyvRIyfluaXNby3rWXDZ29XHvjPsJFfEJPtuH5yLFSTV0V0qxzDZ91XMx j3fTTEDd6IpZ9C0m Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 10 February 2016 19:06:27 Matthias Brugger wrote: > > --- > > I tried this with: > commit 2178cbc68f3602dc0b5949b9be2c8383ad3d93ef > > $ grep 8250 .config > CONFIG_SERIAL_8250=m > # CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set > CONFIG_SERIAL_8250_PCI=m > CONFIG_SERIAL_8250_NR_UARTS=4 > CONFIG_SERIAL_8250_RUNTIME_UARTS=4 > # CONFIG_SERIAL_8250_EXTENDED is not set > # CONFIG_SERIAL_8250_DW is not set > # CONFIG_SERIAL_8250_RT288X is not set > CONFIG_SERIAL_8250_MT6577=y > # CONFIG_SERIAL_8250_INGENIC is not set > # CONFIG_SERIAL_8250_MID is not set > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- drivers/tty/ > > compiles just fine. > > Do I missing something? > I was simplifying the situation in the patch description: When CONFIG_SERIAL_8250=m, Kbuild does not actually descend into drivers/tty/serial/8250/ while building built-in code, so none of the built-in subdrivers actually get built. After spotting the problem, I was building with this patch that I considered submitting: diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile index ceba33c4ebb4..28121885e78e 100644 --- a/drivers/tty/serial/Makefile +++ b/drivers/tty/serial/Makefile @@ -18,7 +18,7 @@ obj-$(CONFIG_SERIAL_SUNSU) += sunsu.o obj-$(CONFIG_SERIAL_SUNSAB) += sunsab.o # Now bring in any enabled 8250/16450/16550 type drivers. -obj-$(CONFIG_SERIAL_8250) += 8250/ +obj-y += 8250/ obj-$(CONFIG_SERIAL_AMBA_PL010) += amba-pl010.o obj-$(CONFIG_SERIAL_AMBA_PL011) += amba-pl011.o However, after the other problems are fixed, it's not actually needed any more, so I did not submit it. Arnd