From: Jijie Shao <shaojijie@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <shaojijie@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<sudongming1@huawei.com>, <xujunsheng@huawei.com>,
<shiyongbang@huawei.com>, <libaihan@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported in this module
Date: Fri, 14 Feb 2025 10:51:28 +0800 [thread overview]
Message-ID: <7594549d-4f5f-4a46-a1c6-b341fc290a43@huawei.com> (raw)
In-Reply-To: <47e8bab3-61cb-4c5a-9b40-03011b6267b3@lunn.ch>
on 2025/2/14 3:54, Andrew Lunn wrote:
> On Thu, Feb 13, 2025 at 11:55:23AM +0800, Jijie Shao wrote:
>> The driver supports many hw statistics. This patch supports
>> dump statistics through ethtool_ops and ndo.get_stats64().
>>
>> The type of hw statistics register is u32,
>> To prevent the statistics register from overflowing,
>> the driver dump the statistics every 5 minutes
>> in a scheduled task.
> u32 allows the counter to reach 4294967295 before wrapping. So over 5
> minutes, that is around 14,316,557 per second. Say this is your
> received byte counter? That means your line rate cannot be higher than
> 114Mbps? Is this device really only Fast Ethernet?
>
> Andrew
Haha, maybe my formula is wrong and I missed a unit conversion.
Thank you very much for pointing out the error. I'll recalculate the correct value.
Jijie Shao
next prev parent reply other threads:[~2025-02-14 2:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 3:55 [PATCH net-next 0/7] Support some enhances features for the HIBMCGE driver Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported in this module Jijie Shao
2025-02-13 19:54 ` Andrew Lunn
2025-02-14 2:51 ` Jijie Shao [this message]
2025-02-13 3:55 ` [PATCH net-next 2/7] net: hibmcge: Add self test " Jijie Shao
2025-02-13 19:59 ` Andrew Lunn
2025-02-14 2:46 ` Jijie Shao
2025-02-14 13:53 ` Andrew Lunn
2025-02-18 1:12 ` Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 3/7] net: hibmcge: Add rx checksum offload " Jijie Shao
2025-02-17 15:40 ` Simon Horman
2025-02-18 2:16 ` Jijie Shao
2025-02-18 2:46 ` Kalesh Anakkur Purayil
2025-02-18 8:27 ` Jijie Shao
2025-02-18 13:42 ` Simon Horman
2025-02-19 1:15 ` Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 4/7] net: hibmcge: Add abnormal irq handling feature " Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 5/7] net: hibmcge: Add mac link exception " Jijie Shao
2025-02-13 20:05 ` Andrew Lunn
2025-02-14 2:39 ` Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 6/7] net: hibmcge: Add BMC diagnose " Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 7/7] net: hibmcge: Add ioctl supported " Jijie Shao
2025-02-13 20:13 ` Andrew Lunn
2025-02-14 2:30 ` Jijie Shao
-- strict thread matches above, loose matches on Subject: below --
2024-10-23 13:42 [PATCH net-next 0/7] Support some features for the HIBMCGE driver Jijie Shao
2024-10-23 13:42 ` [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported in this module Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7594549d-4f5f-4a46-a1c6-b341fc290a43@huawei.com \
--to=shaojijie@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox