From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F9A33431F4 for ; Fri, 14 Nov 2025 15:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134549; cv=none; b=RKN6cIkwhccdXMRKQqm5SYY8YEpclPl442y+c/bd6SflBxsR9YqbRhhw1eLkiqTUZ5EZlaQGf4Lf2WIQIxxtRDcCV95NGeWPCphBqP7qjPK/Ctzpk2X9+XCcctl4iINLRRDx8EkYvT5tzwZG82Ai1vhWV3/ZjsYi2yAhL8r7Mkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763134549; c=relaxed/simple; bh=e6NjvYkso8bEC/sWUEwjOxU38U7QS3viUW3qTS0nnH0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iWIJF0uzuAeuo4eY9hc+LkrGMbQqfmjajQI6bYokIMzOWgbNO7HAbwiHryLDNPctzHhqofgPgZjGZjXPp+fLCC/cO0v54afJPdEOcvC4BHgykQAdIJgfMVikBp7bqGC1517c3gzXbDJPiWB5JfPS9ZghDeeA+Ek3ExbPQ4lLIws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Q1unag8/; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Q1unag8/" Message-ID: <759a8a24-2ed2-4628-b64c-b02428ee07cb@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1763134545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xt5aILFSt7PSgQoMowi/IMdwH4D1+v22HJrwz8wAtmo=; b=Q1unag8/XOadACYHzamxxfIbf0YSgEXiyDvzZPMuD88j0cK1oVK1JpWo/0EuPSl2ycmXl9 C39QRf8IT6j/xGcU3fSPQjJMRjFTWIzvwc/OXAbIxmMhucEbNtKwVYQGzOLsTMgvdlw1XQ Jn+DZKcAi5SyK3hnVyPnrkYG33/Zob4= Date: Fri, 14 Nov 2025 10:35:32 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 3/3] drm: zynqmp: Add blend mode property to graphics plane To: "Klymenko, Anatoliy" , Laurent Pinchart , Tomi Valkeinen , "dri-devel@lists.freedesktop.org" Cc: "linux-kernel@vger.kernel.org" , Mike Looijmans , David Airlie , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" , Simona Vetter , "Simek, Michal" References: <20251113203715.2768107-1-sean.anderson@linux.dev> <20251113203715.2768107-4-sean.anderson@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 11/13/25 18:59, Klymenko, Anatoliy wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > >> -----Original Message----- >> From: Klymenko, Anatoliy >> Sent: Thursday, November 13, 2025 3:04 PM >> To: 'Sean Anderson' ; Laurent Pinchart >> ; Tomi Valkeinen >> ; dri-devel@lists.freedesktop.org >> Cc: linux-kernel@vger.kernel.org; Mike Looijmans ; >> David Airlie ; Thomas Zimmermann >> ; Maarten Lankhorst >> ; Maxime Ripard ; >> linux-arm-kernel@lists.infradead.org; Simona Vetter ; Simek, >> Michal >> Subject: RE: [PATCH 3/3] drm: zynqmp: Add blend mode property to graphics >> plane >> >> Hi Sean, >> >> Thank you for the patch. >> >> > -----Original Message----- >> > From: Sean Anderson >> > Sent: Thursday, November 13, 2025 12:37 PM >> > To: Laurent Pinchart ; Tomi Valkeinen >> > ; dri-devel@lists.freedesktop.org >> > Cc: linux-kernel@vger.kernel.org; Mike Looijmans ; >> > David Airlie ; Thomas Zimmermann >> > ; Maarten Lankhorst >> > ; Klymenko, Anatoliy >> > ; Maxime Ripard ; >> linux- >> > arm-kernel@lists.infradead.org; Simona Vetter ; Simek, >> > Michal ; Sean Anderson >> > >> > Subject: [PATCH 3/3] drm: zynqmp: Add blend mode property to graphics >> plane >> > >> > Caution: This message originated from an External Source. Use proper >> caution >> > when opening attachments, clicking links, or responding. >> > >> > >> > When global alpha is enabled, per-pixel alpha is ignored. Allow >> > userspace to explicitly specify whether to use per-pixel alpha by >> > exposing it through the blend mode property. I'm not sure whether the >> > per-pixel alpha is pre-multiplied or not [1], but apparently it *must* be >> > pre-multiplied so I guess we have to advertise it. >> > >> > [1] All we get is "The alpha value available with the graphics stream >> > will define the transparency of the graphics." >> > >> > Signed-off-by: Sean Anderson >> > --- >> > >> > drivers/gpu/drm/xlnx/zynqmp_kms.c | 24 ++++++++++++++++++++++-- >> > 1 file changed, 22 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c >> > b/drivers/gpu/drm/xlnx/zynqmp_kms.c >> > index 456ada9ac003..fa1cfc16db36 100644 >> > --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c >> > +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c >> > @@ -61,6 +61,13 @@ static int zynqmp_dpsub_plane_atomic_check(struct >> > drm_plane *plane, >> > if (!new_plane_state->crtc) >> > return 0; >> > >> > + if (new_plane_state->pixel_blend_mode != >> > DRM_MODE_BLEND_PIXEL_NONE && >> > + new_plane_state->alpha >> 8 != 0xff) { >> > + drm_dbg_kms(plane->dev, >> > + "Plane alpha must be 1.0 when using pixel alpha\n"); >> > + return -EINVAL; >> > + } >> > + >> > crtc_state = drm_atomic_get_crtc_state(state, new_plane_state->crtc); >> > if (IS_ERR(crtc_state)) >> > return PTR_ERR(crtc_state); >> > @@ -117,9 +124,13 @@ static void >> > zynqmp_dpsub_plane_atomic_update(struct drm_plane *plane, >> > >> > zynqmp_disp_layer_update(layer, new_state); >> > >> > - if (plane->index == ZYNQMP_DPSUB_LAYER_GFX) >> > - zynqmp_disp_blend_set_global_alpha(dpsub->disp, true, >> > + if (plane->index == ZYNQMP_DPSUB_LAYER_GFX) { >> > + bool blend = plane->state->pixel_blend_mode == >> > + DRM_MODE_BLEND_PIXEL_NONE; > > I would suggest adding > || !plane->state->fb->format->has_alpha; > pixel_blend_mode doesn't make a lot of sense for non-alpha formats but may > have a negative effect on Mike's fix > https://lore.kernel.org/dri-devel/20250627145058.6880-1-mike.looijmans@topic.nl/ > if user isn't careful enough around this property. I don't believe that patch should be applied. --Sean >> > + >> > + zynqmp_disp_blend_set_global_alpha(dpsub->disp, blend, >> > plane->state->alpha >> 8); >> > + } >> > >> > /* >> > * Unconditionally enable the layer, as it may have been disabled >> > @@ -179,9 +190,18 @@ static int zynqmp_dpsub_create_planes(struct >> > zynqmp_dpsub *dpsub) >> > return ret; >> > >> > if (i == ZYNQMP_DPSUB_LAYER_GFX) { >> > + unsigned int blend_modes = >> > + BIT(DRM_MODE_BLEND_PIXEL_NONE) | >> > + BIT(DRM_MODE_BLEND_PREMULTI); >> >> | BIT(DRM_MODE_BLEND_COVERAGE) - this is what implemented in the >> hardware. >> >> > + >> > ret = drm_plane_create_alpha_property(plane); >> > if (ret) >> > return ret; >> > + >> > + ret = drm_plane_create_blend_mode_property(plane, >> > + blend_modes); >> > + if (ret) >> > + return ret; >> > } >> > } >> > >> > -- >> > 2.35.1.1320.gc452695387.dirty >> >> Thank you, >> Anatoliy > > Thank you, > Anatoliy >