From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3B132E5405 for ; Wed, 26 Nov 2025 22:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194902; cv=none; b=jlpWBObuptQcP99MRH/N17bCwLFMlEYGBSFwr7F+2aelku3frItAEzETx+aavBVXzwRL0A3iulHt5ptsnwvGEMHg59QqVpeqljlDy5CLiYO781Eo5AU7gQvQzkl1J9O9IPT8o214mj5ti6ko0pHM5jdeWL7NXqvy9HiTX/WU3vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194902; c=relaxed/simple; bh=rtiPfcGehEKgX/iZgoqnie41bS6mGZd2PttvNx6B2JQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kv+eHQbn8Zrek3nUJQ7T4PuE9HtgBV+TaG5WmPbDEjNYAGhb6XqCaoZdiep2Iz8pou3LetIyDghM6LQD6ES+ppMPgCMpaaZMAr1OmbZ1V3ZhGcTwR7k4wf/u8cLnw8ySOyPXe+kmVUhBZ8BM9uDbVtjLLN4MTXHxvEEBwukDR+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U3vQcMdL; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U3vQcMdL" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7bc0cd6a13aso158683b3a.0 for ; Wed, 26 Nov 2025 14:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764194900; x=1764799700; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xgiTZIOx+y+gqr86BpeS1BjQ5eXjgZJupPMHKmu6Swk=; b=U3vQcMdLmk+b+NqjS+i8nAsAzZfWVa3gjHx0VBLxHP5NyIhyGWfkfhq9Q4ShvfEYY2 MkmvbRJWL/LGvmy10OTV/MRm8hllpvFBMPTSslEDaURZSADR0zGgMfJN295u0jdEFKvw TNxfzwKkaFNaY0El2lfQ0VWBGtTEGMMnAsGS4reco4qZCLzOoZSHRe/KpWl5mEvAIwBe MULGv7f4kidv6aUhMP3JTFOVeL3cwRpBTVIUl0fvEygtuEz9bwcSrMnTmyi6CHUSEWMt sCrqKaFOBElPTa+pHsOewnWvSvmIBtU2xu+zeKO/6kg53K048kxHTuAx3icWp9ilgnZb PsZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764194900; x=1764799700; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xgiTZIOx+y+gqr86BpeS1BjQ5eXjgZJupPMHKmu6Swk=; b=u2jS2Fv2BhOdiuQ8+QNb756n1/wk2eqIC/wtQU/EWN3K3qqqzPvda6NnqCTUi82j0P 4rD9RLpmQVj6v0d9rjPwUv4TbXI+nHnTrbO2o9k/dapBheJHrT6FXcFkEcnpVWYqzpb6 3ClJrDvf8PAD81FyERIA8RnsY8AnhvvMQbyiHjsQzc3b63Uf4nRT4gvu2uLT8bAdrjgh yb8mf4kb3BdaTYV48GRnIOB0iGN6QYkdjILXDnJi2rP6pRpLicw+ubXkgxZUa+pUOIZY txL2lTOE6XYxizxESaEPjh3woNxijP3oHbGK7n1DaSmQNJkvAkWQsseli8LCe3lyXHB+ j3ZA== X-Forwarded-Encrypted: i=1; AJvYcCVKqeq1WOrCSKbTw/31QVAWfyUGu7uEnCrw85ALJcg4y4r+WMo1r7rjZ1vLgJOtu4ijaxUPwEriVd5hkug=@vger.kernel.org X-Gm-Message-State: AOJu0YwoxHSXQYwqDHefi8Vpf0nESpu+5erE+WllW4Ezxoe1ZR13kPqf FQSafVyqhaQrCo6W/kH6tDcYF9d/4mHGYptkxXckGfHiX2FAQpPS+mdv X-Gm-Gg: ASbGncuLyjQ1Hi8d38l9yqzcvxtYJREIY2b+ZttNwRNUrV9rU4U6xP9Cw7nSDTxS0cj KCccNDnFrxz1yf75BfApXXqdp2wxRG9Ct3rXt4SbBqxdQbRfX38acdOUVYOXk1OpcLysjnaIbNB KwpFRTsDvVLHQ7pQnmaQ+fu2gCQEdqmJnD52OF4/67pldn5kWka+DvYQzWgMiVzj1x8g5yk1O0E JnALb/mk3hTvenoKtUyUuAtT4PejI0VHPBWHE1UoDJa3rcSs8se6LLKt6m5hkbecwUpt4jIyNdU tdGVJcNIkT+xt8dUnBpFrGvFX80iEGdhd5QzZQ28TSQusEG9J+gMx5Q9UJyI9yMmtJ6IErhwedZ O61eUzmkYCLHkmod4PefwmML6huNaUykkzNb7xDn4/8uXw0/bxwxDXX8OVzBWFRzHEfeuvuIzyl raG2EZ/pBbWFOvW90O6G8/ncAdWhmtPqCaDonWD3fLL4JjY1w0uqKtzWzDRF6f7XzkkNSQbTKd+ b2xDGJ5mB7kVjHDsLkql56S X-Google-Smtp-Source: AGHT+IFB41RdFB/0c7IO7tthz2DW2H1EvC3bEKDG9fDDMR8D4Oy8cmDnnS3vlPgC9fcEZdGEl55zjg== X-Received: by 2002:a05:6a20:4310:b0:35d:b415:7122 with SMTP id adf61e73a8af0-3614f54d36cmr21964226637.26.1764194900156; Wed, 26 Nov 2025 14:08:20 -0800 (PST) Received: from [192.168.2.119] ([103.92.100.179]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd7610a6f80sm20199734a12.32.2025.11.26.14.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Nov 2025 14:08:19 -0800 (PST) Message-ID: <75bbd0a9-1e33-4f63-85ed-de1607aa5e2e@gmail.com> Date: Thu, 27 Nov 2025 03:38:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] most: usb: remove double cleanup of interface on registration failure To: Abdun Nihaal Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20251125225606.70719-1-knavaneeth786@gmail.com> <20251125225606.70719-3-knavaneeth786@gmail.com> Content-Language: en-US From: Navaneeth K In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Nihaal, Thanks for pointing that out. I missed that Johan's patch was already in linux-next. I will drop this patch and send v3 containing only the core fix (which is still needed to prevent the leak). Regards, Navaneeth On 26-11-2025 23:01, Abdun Nihaal wrote: > On Tue, Nov 25, 2025 at 10:56:06PM +0000, Navaneeth K wrote: >> Since most_register_interface() now correctly handles cleanup (calling >> put_device on failure), the manual cleanup in hdm_probe() would cause >> a double-free. >> >> Remove the manual cleanup labels and return the error code directly. > This exact change has already been done by Johan Hovold in the following > patch: https://lore.kernel.org/all/20251029093029.28922-1-johan@kernel.org/ > > I find that patch in Linux-next. It must have been already applied. > and so you can drop this patch. > > Regards, > Nihaal