From: Akihiro TSUKADA <tskd08@gmail.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Colin Ian King <colin.king@canonical.com>,
linux-media@vger.kernel.org, Antti Palosaari <crope@iki.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
mika.batsman@gmail.com
Subject: Re: media: dvb-usb-v2/gl861: ensure USB message buffers DMA'able
Date: Fri, 27 Jul 2018 11:00:25 +0900 [thread overview]
Message-ID: <75be710b-3eda-e077-7c90-beec059d83b2@gmail.com> (raw)
In-Reply-To: <20180725105701.4f3b429b@coco.lan>
Hi,
On 2018年07月25日 22:57, Mauro Carvalho Chehab wrote:
...
> There was another patch proposed to fix this issue with does the
> right thing when rlen == 0. I rebased it on the top of the current
> tree:
> https://git.linuxtv.org/media_tree.git/commit/?id=0b666e1c8120c0b17a8a68aaed58e22011f06ab3
>
> That should cover both cases.
When wlen is checked to be <= 2 and
wbuf[0],wbuf[1] are already used in 'index','value',
why this patch copys wbuf and passes it again in usb_control_msg when wo==1 ?
(just to silence static analiyzers?)
Furthermore,
I am afraid that a static analyzer might warn on a possible
buffer overrun in usb_control_msg in the case of rbuf == NULL && rlen > 2,
since buf's length is passed as rlen but is actually wlen.
regards,
Akihiro
prev parent reply other threads:[~2018-07-27 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 12:58 media: dvb-usb-v2/gl861: ensure USB message buffers DMA'able Colin Ian King
2018-07-03 12:07 ` Akihiro TSUKADA
2018-07-25 13:57 ` Mauro Carvalho Chehab
2018-07-27 2:00 ` Akihiro TSUKADA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75be710b-3eda-e077-7c90-beec059d83b2@gmail.com \
--to=tskd08@gmail.com \
--cc=colin.king@canonical.com \
--cc=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mika.batsman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox