From: Stephen Boyd <sboyd@kernel.org>
To: David Yang <mmyangfl@gmail.com>, linux-clk@vger.kernel.org
Cc: David Yang <mmyangfl@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] clk: hisilicon: Convert to platform driver
Date: Wed, 05 Apr 2023 14:08:40 -0700 [thread overview]
Message-ID: <75e805c3df18d674f1a9816882db5d9f.sboyd@kernel.org> (raw)
In-Reply-To: <20230329075104.165176-4-mmyangfl@gmail.com>
Quoting David Yang (2023-03-29 00:50:52)
> - clk_data);
> - hisi_clk_register_fixed_factor(hi3620_fixed_factor_clks,
> - ARRAY_SIZE(hi3620_fixed_factor_clks),
> - clk_data);
> - hisi_clk_register_mux(hi3620_mux_clks, ARRAY_SIZE(hi3620_mux_clks),
> - clk_data);
> - hisi_clk_register_divider(hi3620_div_clks, ARRAY_SIZE(hi3620_div_clks),
> - clk_data);
> - hisi_clk_register_gate_sep(hi3620_separated_gate_clks,
> - ARRAY_SIZE(hi3620_separated_gate_clks),
> - clk_data);
> -}
> -CLK_OF_DECLARE(hi3620_clk, "hisilicon,hi3620-clock", hi3620_clk_init);
> +static const struct hisi_clocks hi3620_clks = {
> + .nr = HI3620_NR_CLKS,
Can this simply be calculated by adding together all the _num members?
> + .fixed_rate_clks = hi3620_fixed_rate_clks,
> + .fixed_rate_clks_num = ARRAY_SIZE(hi3620_fixed_rate_clks),
> + .fixed_factor_clks = hi3620_fixed_factor_clks,
> + .fixed_factor_clks_num = ARRAY_SIZE(hi3620_fixed_factor_clks),
> + .mux_clks = hi3620_mux_clks,
> + .mux_clks_num = ARRAY_SIZE(hi3620_mux_clks),
> + .divider_clks = hi3620_div_clks
next prev parent reply other threads:[~2023-04-05 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:50 [PATCH v2 0/4] clk: hisilicon: Migrate devm APIs David Yang
2023-03-29 7:50 ` [PATCH v2 1/4] clk: hisilicon: Add helper functions for platform driver David Yang
2023-04-05 19:51 ` Stephen Boyd
2023-03-29 7:50 ` [PATCH v2 2/4] clk: hisilicon: Use helper functions David Yang
2023-04-05 21:06 ` Stephen Boyd
2023-03-29 7:50 ` [PATCH v2 3/4] clk: hisilicon: Convert to platform driver David Yang
2023-04-05 21:08 ` Stephen Boyd [this message]
2023-03-29 7:50 ` [PATCH v2 4/4] clk: hisilicon: Migrate devm APIs David Yang
2023-04-05 19:39 ` [PATCH v2 0/4] " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e805c3df18d674f1a9816882db5d9f.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox