Re: [PATCH v4 06/10] net: eth: altera: Add missing identifier names to function declarations

Thor Thayer
2020-07-23T16:40:03Z

On 7/8/20 2:23 AM, Ooi, Joyce wrote:
> From: Dalon Westergreen <dalon.westergreen@linux.intel.com>
>
> The sgdma and msgdma header files included function declarations
> without identifier names for pointers. Add appropriate identifier
> names.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@linux.intel.com>
> Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
> ---
> v2: this patch is added in patch version 2
> v3: no change
> v4: no change
> ---
> drivers/net/ethernet/altera/altera_msgdma.h | 30 ++++++++++++++-------------
> drivers/net/ethernet/altera/altera_sgdma.h | 32 +++++++++++++++--------------
> 2 files changed, 33 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/net/ethernet/altera/altera_msgdma.h b/drivers/net/ethernet/altera/altera_msgdma.h
> index 9813fbfff4d3..23f5b2a13898 100644
> --- a/drivers/net/ethernet/altera/altera_msgdma.h
> +++ b/drivers/net/ethernet/altera/altera_msgdma.h
> @@ -6,19 +6,21 @@
> #ifndef __ALTERA_MSGDMA_H__
> #define __ALTERA_MSGDMA_H__
>
> -void msgdma_reset(struct altera_tse_private *);
> -void msgdma_enable_txirq(struct altera_tse_private *);
> -void msgdma_enable_rxirq(struct altera_tse_private *);
> -void msgdma_disable_rxirq(struct altera_tse_private *);
> -void msgdma_disable_txirq(struct altera_tse_private *);
> -void msgdma_clear_rxirq(struct altera_tse_private *);
> -void msgdma_clear_txirq(struct altera_tse_private *);
> -u32 msgdma_tx_completions(struct altera_tse_private *);
> -void msgdma_add_rx_desc(struct altera_tse_private *, struct tse_buffer *);
> -int msgdma_tx_buffer(struct altera_tse_private *, struct tse_buffer *);
> -u32 msgdma_rx_status(struct altera_tse_private *);
> -int msgdma_initialize(struct altera_tse_private *);
> -void msgdma_uninitialize(struct altera_tse_private *);
> -void msgdma_start_rxdma(struct altera_tse_private *);
> +void msgdma_reset(struct altera_tse_private *priv);
> +void msgdma_enable_txirq(struct altera_tse_private *priv);
> +void msgdma_enable_rxirq(struct altera_tse_private *priv);
> +void msgdma_disable_rxirq(struct altera_tse_private *priv);
> +void msgdma_disable_txirq(struct altera_tse_private *priv);
> +void msgdma_clear_rxirq(struct altera_tse_private *priv);
> +void msgdma_clear_txirq(struct altera_tse_private *priv);
> +u32 msgdma_tx_completions(struct altera_tse_private *priv);
> +void msgdma_add_rx_desc(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> +int msgdma_tx_buffer(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> +u32 msgdma_rx_status(struct altera_tse_private *priv);
> +int msgdma_initialize(struct altera_tse_private *priv);
> +void msgdma_uninitialize(struct altera_tse_private *priv);
> +void msgdma_start_rxdma(struct altera_tse_private *priv);
>
> #endif /* __ALTERA_MSGDMA_H__ */
> diff --git a/drivers/net/ethernet/altera/altera_sgdma.h b/drivers/net/ethernet/altera/altera_sgdma.h
> index 08afe1c9994f..3fb201417820 100644
> --- a/drivers/net/ethernet/altera/altera_sgdma.h
> +++ b/drivers/net/ethernet/altera/altera_sgdma.h
> @@ -6,20 +6,22 @@
> #ifndef __ALTERA_SGDMA_H__
> #define __ALTERA_SGDMA_H__
>
> -void sgdma_reset(struct altera_tse_private *);
> -void sgdma_enable_txirq(struct altera_tse_private *);
> -void sgdma_enable_rxirq(struct altera_tse_private *);
> -void sgdma_disable_rxirq(struct altera_tse_private *);
> -void sgdma_disable_txirq(struct altera_tse_private *);
> -void sgdma_clear_rxirq(struct altera_tse_private *);
> -void sgdma_clear_txirq(struct altera_tse_private *);
> -int sgdma_tx_buffer(struct altera_tse_private *priv, struct tse_buffer *);
> -u32 sgdma_tx_completions(struct altera_tse_private *);
> -void sgdma_add_rx_desc(struct altera_tse_private *priv, struct tse_buffer *);
> -void sgdma_status(struct altera_tse_private *);
> -u32 sgdma_rx_status(struct altera_tse_private *);
> -int sgdma_initialize(struct altera_tse_private *);
> -void sgdma_uninitialize(struct altera_tse_private *);
> -void sgdma_start_rxdma(struct altera_tse_private *);
> +void sgdma_reset(struct altera_tse_private *priv);
> +void sgdma_enable_txirq(struct altera_tse_private *priv);
> +void sgdma_enable_rxirq(struct altera_tse_private *priv);
> +void sgdma_disable_rxirq(struct altera_tse_private *priv);
> +void sgdma_disable_txirq(struct altera_tse_private *priv);
> +void sgdma_clear_rxirq(struct altera_tse_private *priv);
> +void sgdma_clear_txirq(struct altera_tse_private *priv);
> +int sgdma_tx_buffer(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> +u32 sgdma_tx_completions(struct altera_tse_private *priv);
> +void sgdma_add_rx_desc(struct altera_tse_private *priv,
> + struct tse_buffer *buffer);
> +void sgdma_status(struct altera_tse_private *priv);
> +u32 sgdma_rx_status(struct altera_tse_private *priv);
> +int sgdma_initialize(struct altera_tse_private *priv);
> +void sgdma_uninitialize(struct altera_tse_private *priv);
> +void sgdma_start_rxdma(struct altera_tse_private *priv);
>
> #endif /* __ALTERA_SGDMA_H__ */
>
Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>