Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

Westergreen, Dalon
2020-07-14T15:58:57Z

On Tue, 2020-07-14 at 08:55 -0700, Jakub Kicinski wrote:
> On Tue, 14 Jul 2020 14:35:16 +0000 Ooi, Joyce wrote:
> > > I'm no device tree expert but these look like config options rather than
> > > HW
> > > description. They also don't appear to be documented in the next patch.
> >
> > The poll_freq are part of the msgdma prefetcher IP, whereby it
> > specifies the frequency of descriptor polling operation. I can add
> > the poll_freq description in the next patch.
>
> Is the value decided at the time of synthesis or can the driver choose
> the value it wants?

It is not controlled at synthesis, this parameter should likely not be a
devicetree parameter, perhaps just make it a module parameter with a default
value.

--dalon