Re: [PATCH 1/1] mct_u232: IOCTL implementation

[Tsozik <tsozik@yahoo.com>]

Jesper,

Many thanks for the info. After reading your post I realized that Greg meant that change log comments will be stored in git repository comment section like in any other source control system (e.g. cvs, rcs, ...). So no need to duplicate them in actual file. I will only provide comments in description section of canonical patch format. I'm also wondering if it's OK to provide "git diffs" instead of diffs as a part of patch email? 

Thank you in advance,
 Vadim.

--- On Sun, 12/26/10, Jesper Juhl <jj@chaosbits.net> wrote:

> From: Jesper Juhl <jj@chaosbits.net>
> Subject: Re: [PATCH 1/1] mct_u232: IOCTL implementation
> To: "Tsozik" <tsozik@yahoo.com>
> Cc: "Randy Dunlap" <rdunlap@xenotime.net>, "Greg KH" <gregkh@suse.de>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
> Date: Sunday, December 26, 2010, 5:03 PM
> On Sun, 26 Dec 2010, Tsozik wrote:
> 
> > Randy,
> > 
> > Greg referred to git as to place where change log
> comments are now 
> > checked in. I googled it and found that one can also
> check out latest 
> > kernel source code as opposed to tarball download.
> However, You're 
> > right, looking at 
> > http://kernelnewbies.org/UpstreamMerge/SubmittingPatches
> documentation I 
> > don't see how one can use git to check in comments or
> code directly to 
> > git repository,
> > 
> 
> Only Linus can check code into the final official tree.
> But, you can use 
> git to get a copy of the latest Linus tree (and many other
> trees run by 
> various maintainers and others). Git is also useful for
> maintaining your 
> own local branch with your changes.
> 
> The way it usually works is that you create a patch and
> send it off to 
> some sub-system maintainer via email patch ('git diff'
> generated usually) 
> or via email pull request for your personal repository. The
> sub-system 
> maintainer then merges your patch with his tree and, at a
> later date, 
> submits his tree (including your patch) to Linus.
> 
> Changelog comments are tracked with git. Once your patch is
> accepted it 
> will eventually make its way to Linus' tree and your
> changelog comments in 
> the patch mail (or git commit message - if you send a pull
> request) will 
> eventually turn into a git commit message in the official
> tree. So there's 
> no need to add changelog info in the files themselves.
> Check http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=shortlog
> 
> (or git log after cloning the tree) to see commit
> messages.
> 
> 
> -- 
> Jesper Juhl <jj@chaosbits.net> 
>           http://www.chaosbits.net/
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please.
> 
>