From: Jens Axboe <axboe@kernel.dk>
To: cymi20 <cymi20@fudan.edu.cn>
Cc: "ammarfaizi2@gnuweeb.org" <ammarfaizi2@gnuweeb.org>,
"asml.silence@gmail.com" <asml.silence@gmail.com>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools/io uring: Fix missing check for return value of malloc()
Date: Thu, 15 Jun 2023 07:37:36 -0600 [thread overview]
Message-ID: <763cc719-f62d-529c-a1fd-75cb2554a84b@kernel.dk> (raw)
In-Reply-To: <F5DC6786-D8E5-435F-8FDE-ABD4DD692367@fudan.edu.cn>
On 6/15/23 7:26?AM, cymi20 wrote:
> Actually this checker is driven by inconsistency, it find almost all
> callsite of malloc() in this module has Null check, except this
> callsite.
1) don't top post
2) don't send html emails
But more importantly, actually check the code before making wrong
statements like that.
The patch is pointless.
--
Jens Axboe
next prev parent reply other threads:[~2023-06-15 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 12:50 [PATCH] tools/io_uring: Fix missing check for return value of malloc() Chenyuan Mi
2023-06-15 13:00 ` Ammar Faizi
2023-06-15 13:13 ` Jens Axboe
[not found] ` <F5DC6786-D8E5-435F-8FDE-ABD4DD692367@fudan.edu.cn>
2023-06-15 13:37 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-15 12:53 Chenyuan Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=763cc719-f62d-529c-a1fd-75cb2554a84b@kernel.dk \
--to=axboe@kernel.dk \
--cc=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=cymi20@fudan.edu.cn \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox