The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
	Xu Yang <xu.yang_2@oss.nxp.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE
Date: Sun, 5 Jul 2026 12:04:30 +0100	[thread overview]
Message-ID: <7640db1f-a7fd-46ca-8f2b-b0f6b6d90098@gmail.com> (raw)
In-Reply-To: <6bb87b1f-6877-45bd-a140-48536503259f@rock-chips.com>

Hi Chaoyi,

On 7/5/26 10:37, Chaoyi Chen wrote:
> I think this is reasonable, as x86 works fine without DRM_AUX_HPD_BRIDGE.

Understood, thank you for clarifying.

I think this patch needs a v3 as the commit message and title no
longer match what the patch does and would make the commit history
confusing. Also, in the next version, could you add the changelog and
links to each previous revision below the '---'?

Finally, a link to the original conversation that led to this patch
would be good to add to the body:
https://lore.kernel.org/all/b2633b22-da30-4778-8e23-7b5bed9ead07@rock-chips.com/

Then I will give you my reviewed-by :)

- Julian Braha

  reply	other threads:[~2026-07-05 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-05  6:58 [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE Chaoyi Chen
2026-07-05  9:20 ` Julian Braha
2026-07-05  9:37   ` Chaoyi Chen
2026-07-05 11:04     ` Julian Braha [this message]
2026-07-06  4:38   ` Xu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7640db1f-a7fd-46ca-8f2b-b0f6b6d90098@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=xu.yang_2@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox