public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
Cc: Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	"Peter Newman" <peternewman@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>, <x86@kernel.org>,
	Shaopeng Tan <tan.shaopeng@fujitsu.com>,
	James Morse <james.morse@arm.com>,
	Jamie Iles <quic_jiles@quicinc.com>,
	Babu Moger <babu.moger@amd.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Drew Fustini <dfustini@baylibre.com>,
	<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<patches@lists.linux.dev>
Subject: Re: [PATCH v16 0/9] Add support for Sub-NUMA cluster (SNC) systems
Date: Wed, 20 Mar 2024 08:50:51 -0700	[thread overview]
Message-ID: <7656a3fe-56d2-4a9f-9dfd-6f2666f38110@intel.com> (raw)
In-Reply-To: <5vnrboxpkrriiqcbwrxtbextu6pduqjfchlvsdn5nwe7lr7vou@dngffvu7a5fh>

Hi Maciej,

On 3/20/2024 8:21 AM, Maciej Wieczor-Retman wrote:
> Hi Reinette,
> 
> On 2024-03-19 at 10:51:14 -0700, Reinette Chatre wrote:
>> What remains is the user interface that continues to gather opinions [3]. These new
>> discussions were prompted by user space needing a way to determine if resctrl supports
>> SNC. This started by using the "size" file but thinking about it more user space could
>> also look at whether the number of L3 control domains are different from the number
>> of L3 monitoring domains? I am adding Maciej for his opinion (please also include him
>> in future versions of this series). 
> 
> By this do you mean comparing the contents of main "schemata" file with the
> number of mon_L3_* files?

(assuming you mean mon_L3_* directories)

Yes, the "schemata" file can be used. There is also the "bit_usage" file in
the info directory that indicates how many control domains there are.
Do you think doing so also falls into the "not obvious text parsing and size
comparison" category?

> 
>> Apart from the user space requirement to know if SNC is supported by resctrl there
>> is also the interface with which user space obtains the monitoring data.
>> James highlighted [1] that the interface used in this series uses existing files to
>> represent different content, and can thus be considered as "broken". It is not obvious
>> to me how to "fix" this. Should we continue to explore interfaces like [2] that
>> attempts to add SNC support into resctrl or should the message continue to be
>> that SNC "plays havoc with the RDT monitoring features" and users wanting to use
>> SNC and RDT at the same time are expected to adapt to the peculiar interface ...
>> or is the preference that after this series "SNC and RDT are compatible" and
>> thus presented with an intuitive interface?
> 
> I kind of liked this idea [1]. Hiding SNC related information behind some not
> obvious text parsing and size comparisons might eliminate any ease of use for
> userspace applications. But I agree with you [2] that it's hard to predict the
> future for this interface and any potential problems with setting up this
> file structure.

Thanks to you for trying this out from user space side and highlighting the
difficulty trying to do so.

Reinette

> 
> [1] https://lore.kernel.org/all/SJ1PR11MB608309F47C00F964E16205D6FC2D2@SJ1PR11MB6083.namprd11.prod.outlook.com/
> [2] https://lore.kernel.org/all/7f15a700-f23a-48f9-b335-13ea1735ad84@intel.com/
> 

  reply	other threads:[~2024-03-20 15:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12 21:42 [PATCH v16 0/9] Add support for Sub-NUMA cluster (SNC) systems Tony Luck
2024-03-12 21:42 ` [PATCH v16 1/9] x86/resctrl: Prepare for new domain scope Tony Luck
2024-03-19 17:49   ` Reinette Chatre
2024-03-12 21:42 ` [PATCH v16 2/9] x86/resctrl: Prepare to split rdt_domain structure Tony Luck
2024-03-12 21:42 ` [PATCH v16 3/9] x86/resctrl: Prepare for different scope for control/monitor operations Tony Luck
2024-03-19 17:50   ` Reinette Chatre
2024-03-12 21:42 ` [PATCH v16 4/9] x86/resctrl: Split the rdt_domain and rdt_hw_domain structures Tony Luck
2024-03-12 21:42 ` [PATCH v16 5/9] x86/resctrl: Add node-scope to the options for feature scope Tony Luck
2024-03-12 21:42 ` [PATCH v16 6/9] x86/resctrl: Introduce snc_nodes_per_l3_cache Tony Luck
2024-03-12 21:42 ` [PATCH v16 7/9] x86/resctrl: Sub NUMA Cluster detection and enable Tony Luck
2024-03-12 21:42 ` [PATCH v16 8/9] x86/resctrl: Update documentation with Sub-NUMA cluster changes Tony Luck
2024-03-12 21:42 ` [PATCH v16 9/9] x86/resctrl: Add info files to show mappings from domains to lists of cpus Tony Luck
2024-03-19 17:51 ` [PATCH v16 0/9] Add support for Sub-NUMA cluster (SNC) systems Reinette Chatre
2024-03-19 20:31   ` Luck, Tony
2024-03-19 21:00     ` Reinette Chatre
2024-03-20 15:21   ` Maciej Wieczor-Retman
2024-03-20 15:50     ` Reinette Chatre [this message]
2024-03-20 16:27       ` Maciej Wieczor-Retman
2024-03-21  7:51 ` Maciej Wieczor-Retman
2024-03-21 16:51   ` Luck, Tony
2024-03-22 14:57     ` Maciej Wieczor-Retman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7656a3fe-56d2-4a9f-9dfd-6f2666f38110@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=babu.moger@amd.com \
    --cc=corbet@lwn.net \
    --cc=dfustini@baylibre.com \
    --cc=fenghua.yu@intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=patches@lists.linux.dev \
    --cc=peternewman@google.com \
    --cc=quic_jiles@quicinc.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox