From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbbJLLy0 (ORCPT ); Mon, 12 Oct 2015 07:54:26 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:57508 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbbJLLyY (ORCPT ); Mon, 12 Oct 2015 07:54:24 -0400 From: Arnd Bergmann To: huangdaode Cc: Joe Perches , davem@davemloft.net, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Date: Mon, 12 Oct 2015 13:53:42 +0200 Message-ID: <7677925.qV8yFrBeTx@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <561B2B30.1020400@hisilicon.com> References: <1444620225-2339-1-git-send-email-huangdaode@hisilicon.com> <1444620278.8012.41.camel@perches.com> <561B2B30.1020400@hisilicon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZQmY0KFioSoXOR0AqnE6u5aDwYeD1ofEsFNhBChuRvQUksARW48 VDXeWZEGF/ttjw8Q6CuAt4nT9Ika6Exv3WEV9FAGrcZtvL4JK4yEigAJR6eiSjKIrBIw/Nl XdGhRCW+hqgDKDe5z6DRpEjxEAd8PBZcgO8povWpxlyyh1UcAukywqRLmhov0/0zuMJEVVH N5ZLoVYp40yujmDDF3V5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:R03+Y6QIrzQ=:Q1jk6hWBNzUFrrO+S0A63N QGEqd97Z/P0Ntoz6yAmzQYm/qf81Pp6Re4W9li+jJKyfHTJlhR4d2V5mriJFzuKTfrRTbCyWy n9bDXdBTXY2nNw6m6MY9GESfpp24THdf2Fx32yfQUHNSu+3O4sGT8M4/9EMrEzCDOmsDm30M1 8XKIPQpv30v2fXka1ar2hiRIDXDkaJ1JFtunQUatNXqCD8Dvnw9HXPXc7hGLzXbNlzTe32MCA Z9q2YIZhp9btN+oR97VTlhF6G3ewQOuGwJtbgleCs7r4oNtTRFYEfJUBW4hx5Og5rKLh08Jn3 lKUVR1gfeF6wkTVCvpBYLj1EWqiUD16t8xuaMz7mFLuRGarV4qKzTsrg48TbkgkTxMG6035/P iSI7adfaHDC3VKNlQuwPjhojVfN85ZaKBj2GDa17f4e+dobH0N72KdsBzvUZA5q/YgFxfWmKG FnEcHQWHqvyxPhjX/FHKL7qSx1aCRtV5OQq5XN113NURf1xfg0e2sbjCrjsTL9V7tOIpxDPBO rSEchPjwejgW21I6Df/alSWVpAvtXNq19//u9eAkzIWtMb4TEXiavNyggupuiM5n77WWDMj8W Fi+zW9j97VcYJ3FPsgvxZ7lbWWTT9y2cJ2xKFCVr/0AlSpMHAhwOZI/GNNtloEuUpunWl3Vg9 /fF5q9zWHWqVYiAJrlQv9Ma31YfrAbpU2+MN2pwaOjWrDdR+kNd2qnSVAQ8YB4dCBv8M86Lcd WrWsXyhZxmANNwxb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 October 2015 11:38:24 huangdaode wrote: > On 2015/10/12 11:24, Joe Perches wrote: > > Hello Huang. > > > > On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote: > >> This patch changes the code style to make the code more simple. > >> also removes the once used HNADEL_TX_MSG macro, according to the > > HANDEL_TX_MSG typo > > > >> review comments from Joe Perches. > >> > >> Signed-off-by: huangdaode > >> Reviewed-by: Joe Perches > > I didn't review this. > > ' > Hi Joe > please refer to http://lists.openwall.net/netdev/2015/10/11/61 You should only add the "Reviewed-by" tag to a commit message if the person you are adding replied with this explicitly. Don't add it just because someone gave feedback. Arnd