From: Alex Dubov <oakad@yahoo.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] Results of my work on memorystick subsystem
Date: Tue, 19 Oct 2010 02:40:39 -0700 (PDT) [thread overview]
Message-ID: <767911.16428.qm@web37608.mail.mud.yahoo.com> (raw)
In-Reply-To: <1287410779.20229.9.camel@maxim-laptop>
--- On Mon, 18/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
>
> But for mspro driver, it would be really hard for me to
> split it.
> I have rewritten a lot of code there.
> Can't we just review the end result instead of the patch?
>
> To split the patches, I pretty much need to rewrite the
> whole thing once
> gain.
> I don't want to do that.
>
First, a useful citation (Documentation/HOWTO:548):
"The Linux kernel community does not gladly accept large chunks of code
dropped on it all at once. The changes need to be properly introduced,
discussed, and broken up into tiny, individual portions."
I actually attempted to submit a large "full rewrite" patch early on
during development of one of my drivers. I was a sole developer and it was
not even on a stable tree, as far as I can remember. Yet, that patch was
dropped immediately with the above given reason.
And yes, I had to rewrite the whole thing again, this time in small steps.
next prev parent reply other threads:[~2010-10-19 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 23:12 [PATCH 0/6] Results of my work on memorystick subsystem Maxim Levitsky
2010-10-16 23:12 ` [PATCH 1/6] memstick: core: add series of common helpers Maxim Levitsky
2010-10-16 23:12 ` [PATCH 2/6] memstick: Add driver for Ricoh R5C592 Card reader Maxim Levitsky
2010-10-16 23:12 ` [PATCH 3/6] memstick: jmb38x: Driver rework Maxim Levitsky
2010-10-16 23:12 ` [PATCH 4/6] memstick: add support for legacy memorysticks Maxim Levitsky
2010-10-16 23:12 ` [PATCH 5/6] memstick: mspro_block: refactoring Maxim Levitsky
2010-10-16 23:12 ` [PATCH 6/6] memstick: stop passing useless pointer to card->current_mrq + refactoring Maxim Levitsky
2010-10-17 22:55 ` [PATCH 0/6] Results of my work on memorystick subsystem Maxim Levitsky
2010-10-18 7:05 ` Alex Dubov
2010-10-18 14:06 ` Maxim Levitsky
2010-10-19 9:40 ` Alex Dubov [this message]
2010-10-19 10:47 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=767911.16428.qm@web37608.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox