The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: Jiri Kosina <jikos@kernel.org>
Cc: "Paolo Pisati" <p.pisati@gmail.com>,
	"Benjamin Tissoires" <bentiss@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rebecca Mara Müller" <rebecca.mara@posteo.de>,
	"Luke Jones" <luke@ljones.dev>,
	"Joshua Leivenzon" <hacker1024@users.sourceforge.net>,
	"Ivan Levchenko" <me@livan.pro>,
	"Nathan Chancellor" <nathan@kernel.org>
Subject: Re: [PATCH v4 0/7] HID: asus: ASUS Zenbook Duo keyboard support
Date: Thu, 19 Nov 2026 23:31:48 +0100	[thread overview]
Message-ID: <767edb7d-8c04-4cf4-88fd-de26fe9b7f44@linux.dev> (raw)
In-Reply-To: <op1o5n3o-s3s4-1q2o-65pn-onss079rn780@xreary.bet>

19 nov 2026 22:31:57 Jiri Kosina <jikos@kernel.org>:

> On Tue, 20 Oct 2026, Paolo Pisati wrote:
>
>> Add support for the detachable USB/Bluetooth keyboard of the ASUS
>> Zenbook Duo line (UX8406MA, UX8406CA, UX8407AA): hotkeys, keyboard
>> backlight and the platform profile key, over both transports.
>>
>> This patchset is a collective effort, gathered here:
>>
>>   https://github.com/NeroReflex/asusctl/issues/25
>>
>> Tested on a UX8407AA against 7.3, docked and over Bluetooth: hotkeys,
>> keyboard backlight, Fn+F profile cycling, and the touchpad staying with
>> hid-multitouch.
>>
>> Since v1 the series has been reworked with the help of an LLM coding assistant.
>> It was used to analyse the review comments and the code they point at, to
>> draft the changes and commit messages that address them. I reviewed every change
>> and tested each version on my UX8407AA, docked and over Bluetooth.
>>
>> Changes in v4:
>> - Rebase onto hid.git#for-7.4/asus, now with Denis's "improve the
>>   driver support for laptops" series.
>> - Drop the delayed handshake re-send: Rebecca measured that the
>>   keyboard stays in hotkey mode without it.
>> - 1/7: check one quirk per branch and the transport in a nested if,
>>   initializing rsize_orig and offs so that clang still sees them set;
>>   use u16 and declare new_rsize at the top of the block (Denis).
>> - 2/7: shorten the comment and put it next to the mapping (Denis).
>> - 3/7: shorten the comment (Denis).
>> - 4/7: only handle usage 0x9d on Zenbook Duo keyboards, and take the
>>   worker lock with guard() instead of a goto and a label (Denis). The
>>   IS_REACHABLE() checks stay in C conditionals rather than #if, as
>>   coding-style.rst asks, so both branches keep being compile-checked.
>> - 5/7: list the report sizes of other devices in the comment (Denis).
>> - 6/7: move the entries above the existing HID_GROUP_GENERIC ones, so
>>   that they do not conflict with the T302CHI dock entry in for-next.
>> - New 7/7: keep the input device names the keyboard reports instead of
>>   renaming them to "Asus Keyboard" (Denis).
>> - Add Denis's Reviewed-by to 3/7, 5/7 and 6/7.
>> - Drop the Assisted-by tags, following "docs: remove Assisted-by
>>   references" in linux-next.
>>
>> Changes in v3 and v2: see the v3 cover letter.
>>
>> v3: https://lore.kernel.org/r/20261013104033.36079-1-p.pisati@gmail.com
>> v2: https://lore.kernel.org/r/20261009153459.124752-1-p.pisati@gmail.com
>> v1: https://lore.kernel.org/r/20260513163248.16483-1-p.pisati@gmail.com
>
> Now in hid.git#for-7.5/asus, thanks.
>

Hi Jiri,

Thank you! Tomorrow I will rebase the ROG ally one to sit on top.

Best regards,
Denis

> --
> Jiri Kosina
> SUSE Labs


      reply	other threads:[~2026-11-19 22:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  9:24 [PATCH v4 0/7] HID: asus: ASUS Zenbook Duo keyboard support Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 1/7] HID: asus: Fix up Zenbook Duo report descriptors Paolo Pisati
2026-10-20 17:37   ` Denis Benato
2026-10-20  9:24 ` [PATCH v4 2/7] HID: asus: Add missing Zenbook Duo hotkeys Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 3/7] HID: asus: Force hid-input to bind to the Zenbook Duo hotkey interface Paolo Pisati
2026-10-20 17:39   ` Denis Benato
2026-10-20  9:24 ` [PATCH v4 4/7] HID: asus: Cycle the platform profile from the Zenbook Duo profile key Paolo Pisati
2026-10-20 17:40   ` Denis Benato
2026-10-20  9:24 ` [PATCH v4 5/7] HID: asus: Do not send feature reports larger than declared Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 6/7] HID: asus: add prod-id, quirk for Zenbook Duo keyboard Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 7/7] HID: asus: Keep the Zenbook Duo input device names Paolo Pisati
2026-10-20 17:42   ` Denis Benato
2026-10-21  6:02 ` [PATCH v4 0/7] HID: asus: ASUS Zenbook Duo keyboard support Rebecca Mara Müller
2026-11-18 14:04 ` Paolo Pisati
2026-11-19 21:31 ` Jiri Kosina
2026-11-19 22:31   ` Denis Benato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=767edb7d-8c04-4cf4-88fd-de26fe9b7f44@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=bentiss@kernel.org \
    --cc=hacker1024@users.sourceforge.net \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=me@livan.pro \
    --cc=nathan@kernel.org \
    --cc=p.pisati@gmail.com \
    --cc=rebecca.mara@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox