From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B3A51D959B for ; Sat, 21 Dec 2024 09:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734772857; cv=none; b=QlnJR6emwRepPRH8z4RsVpSHrsqnQG6O/Joe8NGphI/WeonbAVAX2pK+ZIWU3XWb9X30vWSrKyHnsQb6vlX5cw/UF0gV96ZaQlpvoDfDyl/E3MPcWqRJ6ta7u9qAZc7MORbk0cPMff3z3iNO/fNS9z5JcRDwmqItpVWGxlwjH48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734772857; c=relaxed/simple; bh=VHnZv4XouvakSLRVDy7IS8oaB15YN6IWvRDzQGCuB9I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SqsU3J6zmj1VEdV/dMVXAvz/TTEGhxuTbFLDOu8YCX8apbZ42KOlNLvCvWurpKmM70QY0uPrYPNYg3ZFT0MB5kmEkktnO7CvJMMKmZBGSivQ5pzEPymsFInlfzpqbI8DPqRvZPXN45hiaVW2D3XW6Kh2l7czHP6nS6TykMXWm9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Sw+01yZA; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Sw+01yZA" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-385e27c75f4so1987054f8f.2 for ; Sat, 21 Dec 2024 01:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1734772854; x=1735377654; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e0De87n2R9OMl1pqS66ZPnGoUWbdTS9Pio0ovVmKAmI=; b=Sw+01yZAH2gypGA3QP2U/FmENIH+WKZJHdZmwyul3tce+qA2uD3Avqe09a0YxRb+y7 nyi/WJkqUx1p+XOxrave3xE2UDLDY6Kg3t/Bi7tNnzpK6sEVFRkOJ81j9qoMN5e+LJJ0 oDL/Y5ZuT5oBb/wenLHErX9ubcDwAh0aoyNSYRB4PRKKEVCyxAVAkYTcTFlEAfiNfOYS EIN4lJNuLkXXiGJZ/YKQQBdh4EQNcNRF+D8YQ+r/H2PvbGvGMZ0uMFti8/w5kuS+JBHy qrIYWjUNbZGrnN/F1K79hZMzK6DayNIxj/OLkLSOWBSxb3PgCkWK5U4TBJGpitjOEyHb z4wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734772854; x=1735377654; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e0De87n2R9OMl1pqS66ZPnGoUWbdTS9Pio0ovVmKAmI=; b=Dp4wzIrLiUOrXX3fT8I4I2QTjl1LJFiZjzlCEp6fuS6pVSSan7+/5AYXPbMbQSzN6n oCmGMWlfqJLFBnLtssBXYuFEDVuvLFV+wrini86zHupBYCYkyUUVjDGgrBKVaz3OKGDj 5nEZqRV37j7rZxXGMmW/y+y8rYqP10dgzL80otgYYirWvifOSh1hms7F43np60RG9eI7 zmaU1YQ2zkFBe7fQ1P7i4ztEk7D+VoKMXi2Scf/nqc9ERRapo/0zj3wLQi734p5wf4Db 87/MYqg4jvxBIi/2wBjJVRi/inTJXb0bAIam6ngKg3iWdWrllnqW2VbtQFalSAFv86gV yBTA== X-Forwarded-Encrypted: i=1; AJvYcCVtdcXHB+8f+jxliq1dDylV7zqPeEO2kqYuJ8wAgRI826JohNk1v1XrGLJ/oBFAkL9iCpnZc8BHxLBTBmE=@vger.kernel.org X-Gm-Message-State: AOJu0Yysi/KffIzDHak4a5cODiVaBXHQdFk/jRL33klFJFkOdllBGP0i tdBMpUMAWDVfgMKZcjmcVRV4gz65091IZdnwYV2wO6srRBF6+8rBXtqCJd6+4wI= X-Gm-Gg: ASbGnct28XF2j3Gogj1vFCsUmHIYUNfWQOUh/6DnEmnBAaK6D3gSJ0t462yCdMFY0cq RDtbpRuY6HM/byqvrkVAXTaOh/H+ypd2AMQn/YaW6eOi+Lns0b16JEugoJklVkVdjvctT9VyrdB alB2rhg29N19j9HKVBEyO602XxKxSsZ4mXAGBWvhoHzwUn96Tfg+66vrXhA2fi1R5mLGH7Cf2zN LyCe48aMEZHkGe/DKbi1Xzd7HMMBk1zRhaEa9m0Q58M8SB07X+gRci1ZF+4waI6Mg== X-Google-Smtp-Source: AGHT+IHSawxlzvKqoAwoM2xEIw/46BhuVjzkLBsLv+6XyaH9hxc35l2vQOjv8VzuN9mJzjfLSVNtuw== X-Received: by 2002:a05:6000:70a:b0:385:e176:4420 with SMTP id ffacd0b85a97d-38a221e2c89mr5559230f8f.10.1734772853650; Sat, 21 Dec 2024 01:20:53 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.102]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656af6c25sm104008455e9.8.2024.12.21.01.20.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Dec 2024 01:20:52 -0800 (PST) Message-ID: <7685c7a7-3bba-4709-bdb2-1dba22af9146@tuxon.dev> Date: Sat, 21 Dec 2024 11:20:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 3/6] serial: sh-sci: Move runtime PM enable to sci_probe_single() To: Geert Uytterhoeven Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, wsa+renesas@sang-engineering.com, prabhakar.mahadev-lad.rj@bp.renesas.com, lethal@linux-sh.org, g.liakhovetski@gmx.de, groeck@chromium.org, mka@chromium.org, ulrich.hecht+renesas@gmail.com, ysato@users.sourceforge.jp, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea References: <20241204155806.3781200-1-claudiu.beznea.uj@bp.renesas.com> <20241204155806.3781200-4-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19.12.2024 12:18, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Wed, Dec 4, 2024 at 4:58 PM Claudiu wrote: >> From: Claudiu Beznea >> >> Relocate the runtime PM enable operation to sci_probe_single(). This change >> prepares the codebase for upcoming fixes. >> >> While at it, replace the existing logic with a direct call to >> devm_pm_runtime_enable() and remove sci_cleanup_single(). The >> devm_pm_runtime_enable() function automatically handles disabling runtime >> PM during driver removal. >> >> Signed-off-by: Claudiu Beznea > > Thanks for your patch! > >> --- a/drivers/tty/serial/sh-sci.c >> +++ b/drivers/tty/serial/sh-sci.c >> @@ -3440,7 +3434,6 @@ static int sci_probe_single(struct platform_device *dev, >> >> ret = uart_add_one_port(&sci_uart_driver, &sciport->port); >> if (ret) { >> - sci_cleanup_single(sciport); >> return ret; >> } > > Next line is: > > return 0; > > so please just merge that into > > return uart_add_one_port(&sci_uart_driver, &sciport->port); > You're right with these. > Actually [PATCH 5/6] makes that change, but there is no reason not > to do that here. I remember I chose to keep it like this as I had the impression that if I format the patches as proposed by you the 5/6 will just revert what I will have been done in this patch. But I think I was wrong. Thank you, Claudiu > > For the logical changes: > Reviewed-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert >