From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30FAD388E61 for ; Thu, 7 May 2026 14:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778163131; cv=none; b=XVzIOlrlZhMUSyt3t4s4pCWRbczMl+72/h9Ezn1P8YET7OxAH6xGdiMIjk6x4EJ6H975xx7KkJP52UaGSpKasH2a7yCOI1DWfGL8prGoo4gvUe7Ze/4H/dtxhUhfwgd9rp+f78vB2Ju/Ywux969J1YkPrqjZ2aeUT9YDVGmP9LE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778163131; c=relaxed/simple; bh=IfPdZLxkx4Se/6l+tDdfRRRtJTUpSWKEiidzy0SmIDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cXWyXDrgl/nWE2jSrQnDyKLySvYe+xkKeD4tfS3Aekfe5Mxo97UmPDWQUOUT8tPTPHXqKactZ+KLFDf+qkxFg0tN2RYCboceU4LR9EPeDwTc6VUKAMs2Z9vPljAreo66cztMRkPGv9D2z1iAV3rJxPYLSs9h46S9fO6HQ30Ogzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=O6hBsj6g; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="O6hBsj6g" Message-ID: <7688543c-b2c3-477c-b894-643995af08bd@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778163127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JE0MIr1dxYT1PjuTUSJgptucJ/9w1unHy1nCM1mXmt0=; b=O6hBsj6g0S5ocjN2nip6oPyTTlQl5P2zLsr2Xg41JzHb+sfWatttJqPI0eqEDmjPXSeQ+i tqa5JthzG8eNbe9OLX5oDhMq3xH243sB0tJ3FIexw2H4UQxsBtzoEkS+5BTTMV/kobqxUj OXnqXNmMAMLadmqPHKDkTYIGCayGRlg= Date: Thu, 7 May 2026 07:11:38 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] RDMA/nldev: add mutual exclusion in nldev_dellink() To: Edward Adam Davis , "yanjun.zhu@linux.dev" Cc: akpm@linux-foundation.org, arjan@linux.intel.com, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, hdanton@sina.com, horms@kernel.org, jgg@ziepe.ca, kuba@kernel.org, kuni1840@gmail.com, kuniyu@google.com, leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzbot+d8f76778263ab65c2b21@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, zyjzyj2000@gmail.com References: <3c4264e6-2e93-4121-a8ec-5ac20e5cc213@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2026/5/7 6:40, Edward Adam Davis 写道: > On Thu, 7 May 2026 06:25:54 -0700, Zhu Yanjun wrote: >>> We must serialize calls to nldev_dellink() or risk a crash as syzbot >>> reported: >>> >>> KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027] >>> Call Trace: >>> udp_tunnel_sock_release+0x6d/0x80 net/ipv4/udp_tunnel_core.c:197 >>> rxe_release_udp_tunnel drivers/infiniband/sw/rxe/rxe_net.c:294 [inline] >>> rxe_sock_put drivers/infiniband/sw/rxe/rxe_net.c:639 [inline] >>> rxe_net_del+0xfb/0x290 drivers/infiniband/sw/rxe/rxe_net.c:660 >>> rxe_dellink+0x15/0x20 drivers/infiniband/sw/rxe/rxe.c:254 >>> >>> Fixes: a60e3f3d6fba ("RDMA/nldev: Add dellink function pointer") >>> Reported-by: syzbot+d8f76778263ab65c2b21@syzkaller.appspotmail.com >>> Closes: https://syzkaller.appspot.com/bug?extid=d8f76778263ab65c2b21 >>> Tested-by: syzbot+d8f76778263ab65c2b21@syzkaller.appspotmail.com >>> Signed-off-by: Edward Adam Davis >> Thanks a lot. This looks like a good solution. Since the issue is >> reproducible, >> >> have you sent this commit to syzbot for verification? > The patch has been verified by syzbot. Thanks a lot. Reviewed-by: Zhu Yanjun Zhu Yanjun > > BR, > Edward > -- Best Regards, Yanjun.Zhu