From: "Heiko Stübner" <heiko@sntech.de>
To: balbi@ti.com
Cc: Romain Perier <romain.perier@gmail.com>,
devicetree@vger.kernel.org, broonie@kernel.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
grant.likely@linaro.org, robh@kernel.org, mark.rutland@arm.com,
johan@kernel.org, linux-pm@vger.kernel.org, linux@roeck-us.net,
lee.jones@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, swarren@wwwdotorg.org,
thierry.reding@gmail.com, gnurou@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 03/10] regulator: act8865: Use of_is_system_power_controller helper function
Date: Mon, 27 Oct 2014 18:03:51 +0100 [thread overview]
Message-ID: <7689962.rlsfMIoFoC@diego> (raw)
In-Reply-To: <20141027164022.GC14253@saruman>
Am Montag, 27. Oktober 2014, 11:40:22 schrieb Felipe Balbi:
> On Mon, Oct 27, 2014 at 04:26:48PM +0000, Romain Perier wrote:
> > Signed-off-by: Romain Perier <romain.perier@gmail.com>
> > ---
> >
> > drivers/regulator/act8865-regulator.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/regulator/act8865-regulator.c
> > b/drivers/regulator/act8865-regulator.c index 76301ed..435aba1 100644
> > --- a/drivers/regulator/act8865-regulator.c
> > +++ b/drivers/regulator/act8865-regulator.c
> > @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client
> > *client,>
> > return ret;
> >
> > }
> >
> > - if (of_system_has_poweroff_source(dev->of_node)) {
> > + if (of_is_system_power_controller(dev->of_node)) {
>
> so building this driver is broken until this patch ? not very good
> either.
>
> Looks to me you should add of_is_system_power_controller without remove
> of_system_has_poweroff_source() until all users of that have been
> converted over.
or alternatively fold this change into patch1 to keep the renaming together
next prev parent reply other threads:[~2014-10-27 17:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 16:26 [PATCH v1 01/10] of: Rename "poweroff-source" property to "system-power-controller" Romain Perier
2014-10-27 16:26 ` [PATCH v1 02/10] dt-bindings: Document the standard property "system-power-controller" Romain Perier
2014-10-27 16:39 ` Felipe Balbi
2014-10-27 17:26 ` Mark Brown
2014-10-27 17:30 ` Felipe Balbi
2014-10-27 17:57 ` Mark Brown
2014-10-28 7:25 ` Romain Perier
2014-10-27 16:26 ` [PATCH v1 03/10] regulator: act8865: Use of_is_system_power_controller helper function Romain Perier
2014-10-27 16:40 ` Felipe Balbi
2014-10-27 17:03 ` Heiko Stübner [this message]
2014-10-27 16:26 ` [PATCH v2 04/10] ARM: dts: rockchip: Enable power off in pmic for Radxa Rock Romain Perier
2014-10-27 16:26 ` [PATCH v1 05/10] dt-bindings: act8865: Update documentation about property system-power-controller Romain Perier
2014-10-27 16:26 ` [PATCH v2 06/10] mfd: tps65910: Use the standard DT " Romain Perier
2014-10-27 16:35 ` Lucas Stach
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:43 ` Johan Hovold
2014-10-27 16:53 ` Romain Perier
2014-10-27 16:49 ` Heiko Stübner
2014-10-27 16:49 ` Felipe Balbi
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:26 ` [PATCH v2 07/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 apalis Romain Perier
2014-10-27 16:42 ` Felipe Balbi
2014-10-28 4:34 ` Alexandre Courbot
2014-10-28 6:47 ` Romain Perier
2014-10-27 16:26 ` [PATCH v2 08/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 beaver Romain Perier
2014-10-27 16:42 ` Felipe Balbi
2014-10-27 16:26 ` [PATCH v2 09/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 cardhu Romain Perier
2014-10-27 16:26 ` [PATCH v2 10/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 colibri Romain Perier
2014-10-27 16:38 ` [PATCH v1 01/10] of: Rename "poweroff-source" property to "system-power-controller" Felipe Balbi
2014-10-27 16:41 ` Johan Hovold
2014-10-27 16:47 ` Felipe Balbi
2014-10-27 17:02 ` Johan Hovold
2014-10-27 17:05 ` Heiko Stübner
2014-10-27 17:08 ` Felipe Balbi
2014-10-27 17:16 ` Johan Hovold
2014-10-27 18:16 ` Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7689962.rlsfMIoFoC@diego \
--to=heiko@sntech.de \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=romain.perier@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox