From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Hector Martin <marcan@marcan.st>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci: Remove dead code in xhci_move_dequeue_past_td()
Date: Fri, 24 May 2024 11:45:02 +0300 [thread overview]
Message-ID: <768a8ca8-2ca5-1c41-16c2-b0b0421ce645@linux.intel.com> (raw)
In-Reply-To: <20240524-xhci-deadcode-v1-1-a4453a756e0f@marcan.st>
On 24.5.2024 10.07, Hector Martin wrote:
> This codepath is trivially dead, since the function is never called with
> a non-NULL td (the only callsite is immediately preceded by a NULL guard).
>
Yes, thanks, adding to queue.
Comment below tells this was destined to be removed earlier.
> - * We shouldn't hit this anymore as cached cancelled TRBs are given back
> - * after clearing the cache, but be on the safe side and keep it anyway
> - */
> - if (!td) {
...
Thanks
Mathias
next prev parent reply other threads:[~2024-05-24 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 7:07 [PATCH] xhci: Remove dead code in xhci_move_dequeue_past_td() Hector Martin
2024-05-24 8:45 ` Mathias Nyman [this message]
2024-05-24 9:38 ` kernel test robot
2024-05-24 9:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=768a8ca8-2ca5-1c41-16c2-b0b0421ce645@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox