From: Hans de Goede <hdegoede@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] iio: bme680_i2c: Remove ACPI support
Date: Thu, 6 May 2021 15:42:08 +0200 [thread overview]
Message-ID: <768c06ff-663c-eacb-fd3c-628b4e4ba449@redhat.com> (raw)
In-Reply-To: <20210506133754.GA2266661@roeck-us.net>
Hi,
On 5/6/21 3:37 PM, Guenter Roeck wrote:
> On Thu, May 06, 2021 at 12:28:40PM +0300, Andy Shevchenko wrote:
>> On Thu, May 6, 2021 at 6:43 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>>
>>> With CONFIG_ACPI=n and -Werror, 0-day reports:
>>>
>>> drivers/iio/chemical/bme680_i2c.c:46:36: error:
>>> 'bme680_acpi_match' defined but not used
>>>
>>> Apparently BME0680 is not a valid ACPI ID. Remove it and with it
>>> ACPI support from the bme680_i2c driver.
>>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>
>> with the SPI part amended in the same way.
>>
> Right. I just sent a patch doing that. Oddly enough 0-day didn't complain
> about that one to me, nor about many other drivers with the same problem.
> No idea how it decides if and when to make noise.
>
> Is there a way to determine invalid ACPI IDs ?
No, unfortunately not. There is a format which ACPI IDs are
supposed to follow, but some "out in the wild" API ids don't
follow this; and many fake (made up) ACPI ids do follow it...
We (mostly Andy and me) are not even 100% sure this one is
a fake ACPI ID, but we do pretty strongly believe that it is.
Regards,
Hans
next prev parent reply other threads:[~2021-05-06 13:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 3:43 [PATCH v2] iio: bme680_i2c: Remove ACPI support Guenter Roeck
2021-05-06 8:29 ` Hans de Goede
2021-05-06 9:28 ` Andy Shevchenko
2021-05-06 13:37 ` Guenter Roeck
2021-05-06 13:42 ` Hans de Goede [this message]
2021-05-06 13:50 ` Guenter Roeck
2021-05-06 14:31 ` Andy Shevchenko
2021-05-06 14:37 ` Joe Perches
2021-05-06 14:27 ` Andy Shevchenko
2021-05-07 9:31 ` Jonathan Cameron
2021-05-07 13:34 ` Guenter Roeck
2021-05-08 3:09 ` Guenter Roeck
[not found] ` <CAHp75Vfa3GT9bnimxw7EJsJyRF8HZP3PGsUNikSScuNiU4qArg@mail.gmail.com>
2021-05-08 9:41 ` Hans de Goede
2021-05-08 9:47 ` Hans de Goede
2021-05-08 15:24 ` Guenter Roeck
2021-05-08 15:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=768c06ff-663c-eacb-fd3c-628b4e4ba449@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox