From: Dmitry Osipenko <digetx@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Antoni Aloy Torrens" <aaloytorrens@gmail.com>,
"Nikola Milosavljević" <mnidza@outlook.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] power: supply: sbs-battery: Silence warning about unknown chemistry
Date: Fri, 14 May 2021 16:13:39 +0300 [thread overview]
Message-ID: <76b598cc-570e-96ac-8456-0ce481aedaeb@gmail.com> (raw)
In-Reply-To: <20210513151103.hihvxg7kvych4nwr@earth.universe>
13.05.2021 18:11, Sebastian Reichel пишет:
> Hi,
>
> On Tue, May 11, 2021 at 01:08:26AM +0300, Dmitry Osipenko wrote:
>> Older variants of controller don't support reporting type of the battery.
>> Make warning message about unknown chemistry to be printed only once in
>> order to stop flooding kernel log with the message on each request of the
>> property. This patch fixes the noisy messages on Asus Transformer TF101.
>>
>> Tested-by: Antoni Aloy Torrens <aaloytorrens@gmail.com> # TF101
>> Tested-by: Nikola Milosavljević <mnidza@outlook.com> # TF101
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>
> I believe the problem should be fixed as side-effect of the
> following patch:
>
> https://lore.kernel.org/linux-pm/20210513020308.4011440-1-ikjn@chromium.org/
>
> With my suggested change the message is printed once for each
> battery plug, so probably only once per boot for most users.
Looks like that patch indeed should work too, thank you.
prev parent reply other threads:[~2021-05-14 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 22:08 [PATCH v1 1/2] power: supply: sbs-battery: Silence warning about unknown chemistry Dmitry Osipenko
2021-05-10 22:08 ` [PATCH v1 2/2] power: supply: sbs-battery: Fall back to Li-ion battery type for bq20z75 Dmitry Osipenko
2021-05-13 15:31 ` Sebastian Reichel
2021-05-14 13:16 ` Dmitry Osipenko
2021-05-13 15:11 ` [PATCH v1 1/2] power: supply: sbs-battery: Silence warning about unknown chemistry Sebastian Reichel
2021-05-14 13:13 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76b598cc-570e-96ac-8456-0ce481aedaeb@gmail.com \
--to=digetx@gmail.com \
--cc=aaloytorrens@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mnidza@outlook.com \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox