Re: [PATCH 0/2] iio: adc: ti-adc128s052: Add support for adc102s021

Sukrut Bellary
2025-04-15T22:17:54Z

On Sat, Apr 12, 2025 at 02:10:47PM +0100, Jonathan Cameron wrote:
> On Tue, 8 Apr 2025 06:21:18 -0700
> Sukrut Bellary <sbellary@baylibre.com> wrote:
>
> > The patch series adds the support for adc102s021 and family.
> >
> > The family of devices are easier to
> > support since they all (no matter the resolution) seem to respond in
> > 12-bits with the LSBs set to 0 for the reduced resolution devices.
>
> This has raced against Matti's series
> https://lore.kernel.org/linux-iio/cover.1744022065.git.mazziesaccount@gmail.com/
> Support ROHM BD79104 ADC
>
> With hindsight that wasn't obvious from the patch series name though
> which should ideally have been
> iio: adc: ti-adc128s052: Support ROHM BD79104 ADC
>
> Please rebase on the iio testing branch on kernel.org or on top of that series.
> Technically I've only applied the first 7 patches so far, but the 8th
> should be a simple change from that v3.
>
> Matti, you volunteered as maintainer :) Hence please take a look at
> this one.
>
> One nice thing in there is we now have a __be16 buffer16 element that
> can avoid at least one cast in patch 2.

Ok, thanks.
I will work on the top of this series.

> Thanks,
>
> Jonathan
>
> >
> > Changes in v3:
> > Patch 1:
> > - No changes in dt-bindings
> >
> > Patch 2:
> > - used be16_to_cpu() for the endian conversion.
> > - used config index enum while setting up the adc128_config[]
> >
> > - Link to v2:
> > https://lore.kernel.org/lkml/20231022031203.632153-1-sukrut.bellary@linux.com/
> >
> > Changes in v2:
> > Patch 1:
> > - No changes in dt-bindings
> >
> > Patch 2:
> > - Arranged of_device_id and spi_device_id in numeric order.
> > - Used enum to index into adc128_config.
> > - Reorder adc128_config in alphabetical.
> > - Include channel resolution information.
> > - Shift is calculated per resolution and used in scaling and
> > raw data read.
> >
> > - Link to v1: https://lore.kernel.org/all/20220701042919.18180-1-nm@ti.com/
> >
> > Sukrut Bellary (2):
> > dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family
> > iio: adc: ti-adc128s052: Add lower resolution devices support
> >
> > .../bindings/iio/adc/ti,adc128s052.yaml | 6 +
> > drivers/iio/adc/ti-adc128s052.c | 149 +++++++++++++-----
> > 2 files changed, 118 insertions(+), 37 deletions(-)
> >
>