From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 946704596E for ; Wed, 26 Jun 2024 07:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719387965; cv=none; b=Nw5eO+Tu5EuijBl02FEztos/XoG2WVZwJNoym0WWzfkSGffgpBawcBmWKGSpapU+HGZ1o6OGq2poAlm85gDrx1yDvpbt3WGu+7Vt2G7E/XOyfr2fbihrPZe7Lh3YCMdxRMmFI7K2o9j8zBhe7KwoutPJLBQhHv7PmqwgNIxgyBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719387965; c=relaxed/simple; bh=+S/ZylBo7OkDhqSowKwWFObaRLnN9nAxnObxD0rGb+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lh+zkGOVqwGcjM6ubcaI2qI+vKpGQoncuyT0VJIvCMau9QsjlXslsdRzaX+ngfZLA0/xZyUiD/oFuR+ZduC1BPqQI1lEPW6BkLszd2hOCBhvUtuwNOW3XLyC3O7HHZPJBlfSBKQ2ytwYoDP87cDxFaIvUtnAuZIuRQfI7mqxdEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=PDRuAxX5; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="PDRuAxX5" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52cdf579dd2so3869334e87.3 for ; Wed, 26 Jun 2024 00:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1719387962; x=1719992762; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6nCZo+jWMRZ6cgUq9Mxe++DtYRLBTMuxAvEuWj2mzpc=; b=PDRuAxX5PEoFRCnLtzb8Qail2JRo6XlJkOioQfY/45Q2Pe5Q4H1J/Zu/9KyxNujnRg S2J0xUcVG4F+oPIm4+Eu5LhVZAYM5/fLmUMAhuzLqeTy2ImN1BIrqO4aFYIdDLNui4Ee zQwemIPBseh0/06zstorqGL/VsXG0M2rI5dIFNewRRQ+MN4PyT+wGyhK3+hg98tvrBf2 Kjm82niL0hF4Qi1ELGQKJACSn83OG1GjL5s6SuIM5WoCHD+9AX/c1sNt/uOr1n/dWFfU aPE+pPHRQPFLSxyks5E72AX50YoeEwEQaoLgAOcnFB0JxhNyMd1pAuBqXBcOVL6kbRkv xG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719387962; x=1719992762; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6nCZo+jWMRZ6cgUq9Mxe++DtYRLBTMuxAvEuWj2mzpc=; b=Gs3knmX6HgWeJkGLa5VJZam7usZXx0JLhJInU1Tv9mPGlJiFOgvgN0y95osbh00bb9 4FWVwNp7IMndVKs+ax1S5rtPuuW4o/dqaLLrosUCMUeBJB8lJW+4snncVUR8o60fx45C v4hS3jId06HVEwZ7frU/err6vP9zthDzzT/8ikO6EOJLGrjSK29DaE1TNcWZpr7sxHf/ 2rdI/+QQVfqfpbJcSmybu3Tf6WQe1neBja7w5GdSorz5yblgffx7DpqIvAw35enhaHoH YpGXsgEayiS5bsBX4RoA3leUAb3jtUClVqOF8lfe7+4eSqhi906QaJi1TCl8YPQSok+Z VLGA== X-Forwarded-Encrypted: i=1; AJvYcCWVR5EePQmzxCs2NhmTxV6i2LSnw4cQnowdz3momSsGgecoaC22fVlXbUsV8Ak0tivpVZbezlit8jVga/9HYbbPTd1SLWQukoegbht2 X-Gm-Message-State: AOJu0YyKberuzNgPacsfmJ1NZeiWEh6qRuD1WXc7zbsmJsrED75RGBH7 GsvRlRHgySD7VHwcBJTUVC2RgB1xJFfyOqwN/Ca7h/zhh5F/FO6SiFXZ5xwOAs0= X-Google-Smtp-Source: AGHT+IGQX0elEmsIgSgrE2SLocb/u9Th6sLY7fmx7i7FDBNC/6k6+LF/g+fLJC0OABw8GNYDkrkA2Q== X-Received: by 2002:a05:6512:138a:b0:52c:f521:b1c6 with SMTP id 2adb3069b0e04-52d3ad9e8efmr2137151e87.30.1719387961780; Wed, 26 Jun 2024 00:46:01 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424c8246b1dsm15205005e9.6.2024.06.26.00.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jun 2024 00:46:00 -0700 (PDT) Message-ID: <76fc0a6c-b20c-4ae0-bb4f-0023cb66962a@tuxon.dev> Date: Wed, 26 Jun 2024 10:45:59 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] mmc: tmio: Use MMC core APIs to control the vqmmc regulator Content-Language: en-US To: Prabhakar , Ulf Hansson , Wolfram Sang , Geert Uytterhoeven , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , linux-mmc@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar References: <20240624153229.68882-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20240624153229.68882-3-prabhakar.mahadev-lad.rj@bp.renesas.com> From: claudiu beznea In-Reply-To: <20240624153229.68882-3-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24.06.2024 18:32, Prabhakar wrote: > From: Lad Prabhakar > > Use the mmc_regulator_enable_vqmmc() and mmc_regulator_disable_vqmmc() APIs > to enable/disable the vqmmc regulator. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Wolfram Sang > Reviewed-by: Geert Uytterhoeven \ Tested-by: Claudiu Beznea # on RZ/G3S > --- > v2->v3 > - Included RB tags > > v1->v2 > - New patch > --- > drivers/mmc/host/tmio_mmc_core.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c > index 93e912afd3ae..2ec1a74c85bc 100644 > --- a/drivers/mmc/host/tmio_mmc_core.c > +++ b/drivers/mmc/host/tmio_mmc_core.c > @@ -897,8 +897,8 @@ static void tmio_mmc_power_on(struct tmio_mmc_host *host, unsigned short vdd) > * It seems, VccQ should be switched on after Vcc, this is also what the > * omap_hsmmc.c driver does. > */ > - if (!IS_ERR(mmc->supply.vqmmc) && !ret) { > - ret = regulator_enable(mmc->supply.vqmmc); > + if (!ret) { > + ret = mmc_regulator_enable_vqmmc(mmc); > usleep_range(200, 300); > } > > @@ -911,8 +911,7 @@ static void tmio_mmc_power_off(struct tmio_mmc_host *host) > { > struct mmc_host *mmc = host->mmc; > > - if (!IS_ERR(mmc->supply.vqmmc)) > - regulator_disable(mmc->supply.vqmmc); > + mmc_regulator_disable_vqmmc(mmc); > > if (!IS_ERR(mmc->supply.vmmc)) > mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, 0);