Re: [PATCH v3 12/29] media: iris: implement s_fmt, g_fmt and try_fmt ioctls

Bryan O'Donoghue
2024-09-24T14:41:56Z

On 27/08/2024 11:05, Dikshita Agarwal via B4 Relay wrote:
> From: Vedang Nagar <quic_vnagar@quicinc.com>
>
> Implement s_fmt, g_fmt and try_fmt IOCTL ops in
> the driver with necessary hooks.
>
> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>

> +
> + src_q = v4l2_m2m_get_src_vq(m2m_ctx);
> + memset(pixmp->reserved, 0, sizeof(pixmp->reserved));
> + if (V4L2_TYPE_IS_OUTPUT(f->type)) {
> + if (f->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_H264) {
> + f_inst = inst->fmt_src;
> + f->fmt.pix_mp.width = f_inst->fmt.pix_mp.width;
> + f->fmt.pix_mp.height = f_inst->fmt.pix_mp.height;
> + f->fmt.pix_mp.pixelformat = f_inst->fmt.pix_mp.pixelformat;
> + }
> + } else if (V4L2_TYPE_IS_CAPTURE(f->type)) {
> + if (f->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_NV12) {
> + f_inst = inst->fmt_dst;
> + f->fmt.pix_mp.pixelformat = f_inst->fmt.pix_mp.pixelformat;
> + f->fmt.pix_mp.width = f_inst->fmt.pix_mp.width;
> + f->fmt.pix_mp.height = f_inst->fmt.pix_mp.height;
> + }
> + if (vb2_is_streaming(src_q)) {
> + f_inst = inst->fmt_src;
> + f->fmt.pix_mp.height = f_inst->fmt.pix_mp.height;
> + f->fmt.pix_mp.width = f_inst->fmt.pix_mp.width;
> + }
> + } else {
> + return -EINVAL;
> + }
> +

<snip>

> +int iris_vdec_s_fmt(struct iris_inst *inst, struct v4l2_format *f)
> +{
> + struct v4l2_format *fmt, *output_fmt;
> + struct vb2_queue *q;
> + u32 codec_align;
> +
> + int ret = 0;
> +
> + q = v4l2_m2m_get_vq(inst->m2m_ctx, f->type);
> + if (!q)
> + return -EINVAL;
> +
> + iris_vdec_try_fmt(inst, f);
> +
> + if (V4L2_TYPE_IS_OUTPUT(f->type)) {

<snip>

> +
> + } else if (V4L2_TYPE_IS_CAPTURE(f->type)) {

<snip>
> + } else {
> + return -EINVAL;
> + }

I'd switch this instead of if/elsing.

A blanket comment for this series.