public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilya V. Matveychikov" <matvejchikov@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH RFC] ctype: update comments
Date: Tue, 10 May 2016 17:43:55 +0300	[thread overview]
Message-ID: <7702210.VDiUoWCC56@kitchen> (raw)

We have isspace() which may be used incorrectly as one might expect that
it has the same meaning as POSIX isspace(). Also, kernel has outdated
comment about of what is space and hard space exactely.

Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
---
 include/linux/ctype.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/include/linux/ctype.h b/include/linux/ctype.h
index 653589e..5c03748 100644
--- a/include/linux/ctype.h
+++ b/include/linux/ctype.h
@@ -11,9 +11,20 @@
 #define _D	0x04	/* digit */
 #define _C	0x08	/* cntrl */
 #define _P	0x10	/* punct */
-#define _S	0x20	/* white space (space/lf/tab) */
+#define _S	0x20	/* space
+			   0x09 - Horizontal Tab (HT)
+			   0x0A - Line Feed (LF)
+			   0x0B - Vertical Tab (VT)
+			   0x0C - Form Feed (FF)
+			   0x0D - Carriage Return (CR)
+			   0x20 - Space (SP)
+			   0xA0 - Non-Breakable Space (NBSP)
+			*/
 #define _X	0x40	/* hex digit */
-#define _SP	0x80	/* hard space (0x20) */
+#define _SP	0x80	/* hard space
+			   0x20 - Space (SP)
+			   0xA0 - Non-Breakable Space (NBSP)
+			 */
 
 extern const unsigned char _ctype[];
 
-- 
2.8.0

                 reply	other threads:[~2016-05-10 14:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7702210.VDiUoWCC56@kitchen \
    --to=matvejchikov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox