From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6965221545 for ; Mon, 17 Mar 2025 09:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742202517; cv=none; b=ibq5Z7fgeFIwe473UddR5vm37lsXr5azzOqNRtMZmEUX60Zi9svQe+V9/Y5/FM0e1TM8IZcuaf1Uv6corpYkPBF7j+ElQQSdny+EdHLs8nArEq0Dvd9AzFl86bToH8k3LktcNQpTdFaNr9GPj3GH2uL0iKhWsUsyP64269kq73M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742202517; c=relaxed/simple; bh=Mvvbh0DDMRiK6miWCiwmpqH/0S/RSOBLo8iD/n/pR/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gUr31ViWTs33U5Lta3g09/hyQmm0ig+uX/lhGAhpj49OAEN8G1mTQAvQ37wtMBDxI/GjR78ODyLtnOmIVE9w2XrADJQW3QVo5L8xqF7DQEt4feJvHTSucl6SvcqmmriGVzydXKKryHXPIQYNfzIJBm3fI3ImHavuAaiOZe+ZeNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ct5qDh/J; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ct5qDh/J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742202514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUxnWcopxnoAhgCDsSFoLxlEg/lKC1XzCkjkry+Y1ZU=; b=ct5qDh/JSX7PdWrP967/2nsL6yi1xBRNtzz7Dn2OWonwCKQfHRNDsfRU3RE5T0SEtc7CV7 JopwsDOrLMiKaepOXvVPKPHYtoMOw/STsWfKsBFP8Ag+AYj7upm12PGA2pIuhIVnfJXIXO Yh6NXQudx10DUIsuCL5ubngtg2lF5oM= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-2j40Kp29Pjiu_Ovn-wi-xA-1; Mon, 17 Mar 2025 05:08:33 -0400 X-MC-Unique: 2j40Kp29Pjiu_Ovn-wi-xA-1 X-Mimecast-MFC-AGG-ID: 2j40Kp29Pjiu_Ovn-wi-xA_1742202512 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ac2db121f95so339563766b.1 for ; Mon, 17 Mar 2025 02:08:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742202512; x=1742807312; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OUxnWcopxnoAhgCDsSFoLxlEg/lKC1XzCkjkry+Y1ZU=; b=rvqcrqnqtuHlxPkmh3izn4Nwn0Svw4QxwOlK4rZSLpAGsFfLeJYDtNlOOgybc2tFP2 WGI7LHD2idutVT+6QfTw8cHViP77Z/6524e0yyY4yYINqF/T/c+MhbRHlPI1LJ4PkbGu 7N+2tk5fxy72N9YfmV4XIWmZjyr+L9VbjthPX6GAlVmR2fImIWKjAu6UmxuwExXIzs5F 0Yw7a2GFxI1S8Q6Fvxa/GXZmMIthpyHq83cTbePKeLOLtdTrpbucQstZrefFuOxQeypR ltR5HPpG9uEKjx8loXddH3JYBU8Qf8Y+hGiH/qeZfnoUbQVf6pHd0FiKXCDk/NxJtwWO Ufig== X-Forwarded-Encrypted: i=1; AJvYcCUrtgaLC0PGJntCZ104WGUhC0aiMRvy3nwX+FpH0uAYcjkfNoIxtErC20+p9od8VfcR54R24MkPzeIG4XA=@vger.kernel.org X-Gm-Message-State: AOJu0YwNPCoCIP24xgKwhnL6jBV6nfLyszT+lrZrpKdQH4K8eYYbz+zq gn0lFZvaTvZ5Dk7fjS6C2ZLRTgJW/ekkdEPeOy5pt4WV9dZDEZfXyZXfYy6rlN9wIzHuKU3lzJl 5XHze40dYh42kjs9qwsjdxwuaUGiYb9SSkKmECm5vo3DvxtS+6TJ+/VEy9xVRhcHjBrPEJYaa X-Gm-Gg: ASbGncv+Z7GQuLz+1LZmNltlK8ZTfaOVhGE/afayql4vRpKkH+uL1EtEmlg5KCKMNSN MKHmiWPe2Jjpqfr1pessx0yZHZ+aVY3hN+DNxlY1pYTbjUAq/ZLxcVO6k/GWDcCdgvnrcPhq7o7 1nBvvjj37CGV3o/GbAyimbA2M4iKvcb34mceYMkIl9uTng3q8MDL68et4z/yur3P6v0Gz1QEOrp ZZSTAehxnIsOBEyE+iEm9Db1yPvhBpLSEYPPYpjKkt5SvYHrlooC13LL9bI9lrQ5wyc8hhgmFXF AViHq/+hHo9PGMQFdUg= X-Received: by 2002:a17:907:6ea9:b0:ac2:e2bf:d437 with SMTP id a640c23a62f3a-ac3303defb7mr1289818866b.52.1742202511680; Mon, 17 Mar 2025 02:08:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmMlwZG7U70Z6pyeZp1t0JdJ780owI88UMoZl46g79qE+kJtjGHcJF7BeCcZnIxxakzcQWHQ== X-Received: by 2002:a17:907:6ea9:b0:ac2:e2bf:d437 with SMTP id a640c23a62f3a-ac3303defb7mr1289816766b.52.1742202511336; Mon, 17 Mar 2025 02:08:31 -0700 (PDT) Received: from [10.40.98.122] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3146aea1fsm625177366b.22.2025.03.17.02.08.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Mar 2025 02:08:30 -0700 (PDT) Message-ID: <77079344-5355-4595-a56c-26bf2e39e52c@redhat.com> Date: Mon, 17 Mar 2025 10:08:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] drm: panel-orientation-quirks: Add OneXPlayer X1 AMD and Intel quirk To: Antheas Kapenekakis , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jiri Kosina , Benjamin Tissoires References: <20250222164321.181340-1-lkml@antheas.dev> <20250222164321.181340-2-lkml@antheas.dev> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20250222164321.181340-2-lkml@antheas.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 22-Feb-25 17:43, Antheas Kapenekakis wrote: > The OneXPlayer X1 series features a 2k 10.95 display with a portrait > orientation. Add a quirk to set the panel orientation to portrait mode > to both the Intel and AMD variants. > > Signed-off-by: Antheas Kapenekakis Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c > index 4a73821b81f6..17b4f57d64d7 100644 > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > @@ -443,6 +443,24 @@ static const struct dmi_system_id orientation_data[] = { > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"), > }, > .driver_data = (void *)&lcd1600x2560_leftside_up, > + }, { /* OneXPlayer X1 AMD */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 A"), > + }, > + .driver_data = (void *)&lcd1600x2560_leftside_up, > + }, { /* OneXPlayer X1 AMD Strix Point */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1Pro"), > + }, > + .driver_data = (void *)&lcd1600x2560_leftside_up, > + }, { /* OneXPlayer X1 Intel */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ONE-NETBOOK"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER X1 i"), > + }, > + .driver_data = (void *)&lcd1600x2560_leftside_up, > }, { /* OrangePi Neo */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),