From: Lu Baolu <baolu.lu@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@nvidia.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 01/10] iommu/vt-d: Move DMAR specific helpers into dmar.c
Date: Tue, 8 Feb 2022 12:27:16 +0800 [thread overview]
Message-ID: <771436d6-fda5-eeae-16ee-4cb760a056bb@linux.intel.com> (raw)
In-Reply-To: <20220207070849.GA23941@lst.de>
On 2/7/22 3:08 PM, Christoph Hellwig wrote:
>> --- a/include/linux/dmar.h
>> +++ b/include/linux/dmar.h
>> @@ -52,6 +52,32 @@ struct dmar_drhd_unit {
>> struct intel_iommu *iommu;
>> };
>>
>> +struct dmar_rmrr_unit {
>
>> +struct dmar_atsr_unit {
>
>> +struct dmar_satc_unit {
>
> What about moving all code that is using the structures to dmar.c
> to keep the definitions local?
>
It's difficult. References to these structures are scattered in iommu.c.
Best regards,
baolu
next prev parent reply other threads:[~2022-02-08 4:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 6:41 [PATCH v1 00/10] iommu/vt-d: Some Intel IOMMU cleanups Lu Baolu
2022-02-07 6:41 ` [PATCH v1 01/10] iommu/vt-d: Move DMAR specific helpers into dmar.c Lu Baolu
2022-02-07 7:08 ` Christoph Hellwig
2022-02-08 4:27 ` Lu Baolu [this message]
2022-02-07 6:41 ` [PATCH v1 02/10] iommu/vt-d: Remove intel_iommu::domains Lu Baolu
2022-02-07 7:09 ` Christoph Hellwig
2022-02-07 6:41 ` [PATCH v1 03/10] iommu/vt-d: Remove finding domain in dmar_insert_one_dev_info() Lu Baolu
2022-02-07 7:10 ` Christoph Hellwig
2022-02-07 6:41 ` [PATCH v1 04/10] iommu/vt-d: Remove iova_cache_get/put() Lu Baolu
2022-02-07 7:10 ` Christoph Hellwig
2022-02-07 10:39 ` John Garry
2022-02-08 4:29 ` Lu Baolu
2022-02-07 6:41 ` [PATCH v1 05/10] iommu/vt-d: Remove domain and devinfo mempool Lu Baolu
2022-02-07 7:10 ` Christoph Hellwig
2022-02-07 6:41 ` [PATCH v1 06/10] iommu/vt-d: Remove DEFER_DEVICE_DOMAIN_INFO Lu Baolu
2022-02-07 7:12 ` Christoph Hellwig
2022-02-08 4:31 ` Lu Baolu
2022-02-07 6:41 ` [PATCH v1 07/10] iommu/vt-d: Use an xarray for global device_domain_info Lu Baolu
2022-02-07 7:14 ` Christoph Hellwig
2022-02-08 4:38 ` Lu Baolu
2022-02-07 6:41 ` [PATCH v1 08/10] iommu/vt-d: Use rculist for dmar_domain::devices Lu Baolu
2022-02-07 6:41 ` [PATCH v1 09/10] iommu/vt-d: Refactor dmar_insert_one_dev_info() Lu Baolu
2022-02-07 18:27 ` Jacob Pan
2022-02-08 4:55 ` Lu Baolu
2022-02-25 22:09 ` Jacob Pan
2022-02-07 6:41 ` [PATCH v1 10/10] iommu/vt-d: Some cleanups in iommu.c Lu Baolu
2022-02-07 7:15 ` Christoph Hellwig
2022-02-08 4:58 ` Lu Baolu
2022-02-11 13:01 ` [PATCH v1 00/10] iommu/vt-d: Some Intel IOMMU cleanups Jason Gunthorpe
2022-02-14 0:26 ` Lu Baolu
2022-02-14 2:59 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771436d6-fda5-eeae-16ee-4cb760a056bb@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox