From: David Laight <David.Laight@ACULAB.COM>
To: 'Eric Biggers' <ebiggers@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
gaochao <gaochao49@huawei.com>, Ard Biesheuvel <ardb@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH crypto v2] crypto: blake2s - remove shash module
Date: Mon, 30 May 2022 07:37:18 +0000 [thread overview]
Message-ID: <7719057c0de047ebacea46ab9588da44@AcuMS.aculab.com> (raw)
In-Reply-To: <YpJZqJd9j1gEOdTe@sol.localdomain>
From: Eric Biggers
> Sent: 28 May 2022 18:20
>
> On Sat, May 28, 2022 at 11:57:01AM +0200, Jason A. Donenfeld wrote:
> > > Also, the wrong value is being passed for the 'inc' argument.
> >
> > Are you sure? Not sure I'm seeing what you are on first glance.
>
> Yes, 'inc' is the increment amount per block. It needs to always be
> BLAKE2S_BLOCK_SIZE unless a partial block is being processed.
IIRC it isn't used for partial blocks.
Which rather begs the question as to why it is a parameter at all.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-05-30 7:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 9:20 [PATCH crypto] crypto: blake2s - remove shash module Jason A. Donenfeld
2022-05-26 18:01 ` Eric Biggers
2022-05-27 8:05 ` Jason A. Donenfeld
2022-05-27 8:11 ` [PATCH crypto v2] " Jason A. Donenfeld
2022-05-27 12:36 ` David Laight
2022-05-27 13:20 ` Jason A. Donenfeld
2022-05-28 3:59 ` Eric Biggers
2022-05-28 9:57 ` Jason A. Donenfeld
2022-05-28 10:07 ` [PATCH crypto v3] " Jason A. Donenfeld
2022-05-28 17:19 ` [PATCH crypto v2] " Eric Biggers
2022-05-28 19:33 ` Jason A. Donenfeld
2022-05-28 19:44 ` [PATCH crypto v4] " Jason A. Donenfeld
2022-06-10 9:16 ` Herbert Xu
2022-05-30 7:37 ` David Laight [this message]
2022-05-30 7:54 ` [PATCH crypto v2] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7719057c0de047ebacea46ab9588da44@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=gaochao49@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox