From: David Hildenbrand <david@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the mm-unstable tree
Date: Fri, 11 Jul 2025 08:28:03 +0200 [thread overview]
Message-ID: <771f0f0d-832c-4514-b56e-064ba093c5e1@redhat.com> (raw)
In-Reply-To: <20250710153017.c17ca59f1df36eec90db8b54@linux-foundation.org>
On 11.07.25 00:30, Andrew Morton wrote:
> On Thu, 10 Jul 2025 17:54:46 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
>> Hi all,
>>
>> After merging the mm-unstable tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
Hi,
>> mm/migrate.c:215: warning: Function parameter or struct member 'dst' not described in 'migrate_movable_ops_page'
>> mm/migrate.c:215: warning: Function parameter or struct member 'src' not described in 'migrate_movable_ops_page'
>> mm/migrate.c:215: warning: Function parameter or struct member 'mode' not described in 'migrate_movable_ops_page'
>> mm/migrate.c:215: warning: Excess function parameter 'page' description in 'migrate_movable_ops_page'
>>
>> Introduced by commit
>>
>> d5967fb0bf8e ("mm/migrate: factor out movable_ops page handling into migrate_movable_ops_page()")
>
Thanks Andrew for taking care of this, was out the last two days.
> How about this?
>
> --- a/mm/migrate.c~mm-migrate-factor-out-movable_ops-page-handling-into-migrate_movable_ops_page-fix
> +++ a/mm/migrate.c
> @@ -161,7 +161,9 @@ static void putback_movable_ops_page(str
>
> /**
> * migrate_movable_ops_page - migrate an isolated movable_ops page
> - * @page: The isolated page.
> + * @dst: The destination page.
> + * @src: The source page.
> + * @mode: The migration mode.
LGTM, thanks!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-07-11 6:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 7:54 linux-next: build warning after merge of the mm-unstable tree Stephen Rothwell
2025-07-10 22:30 ` Andrew Morton
2025-07-10 22:49 ` Stephen Rothwell
2025-07-11 0:36 ` Randy Dunlap
2025-07-11 6:28 ` David Hildenbrand [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-09-04 2:14 Stephen Rothwell
2025-09-04 2:59 ` Andrew Morton
2025-09-04 6:33 ` David Hildenbrand
2025-07-15 8:55 Stephen Rothwell
2025-07-15 18:54 ` SeongJae Park
2025-07-10 7:50 Stephen Rothwell
2025-07-11 9:57 ` David Hildenbrand
2025-06-10 4:33 Stephen Rothwell
2025-06-10 4:35 ` Christoph Hellwig
2025-05-09 9:43 Stephen Rothwell
2025-05-09 20:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=771f0f0d-832c-4514-b56e-064ba093c5e1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).