From: Zenghui Yu <zenghui.yu@linux.dev>
To: Mark Brown <broonie@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/cpufeature: Use ARM64_CPUID_FIELD() to match EVT
Date: Wed, 19 Jul 2023 22:53:40 +0800 [thread overview]
Message-ID: <77417a3a-597f-b503-acc0-9c6afcaac511@linux.dev> (raw)
In-Reply-To: <20230718-arm64-evt-cpuid-helper-v1-1-68375d1e6b92@kernel.org>
On 2023/7/19 03:45, Mark Brown wrote:
> The recently added Enhanced Virtualization Traps cpufeature does not use
> the ARM64_CPUID_FIELDS() helper, convert it to do so. No functional
> change.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm64/kernel/cpufeature.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index f9d456fe132d..bcb006390e55 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2708,12 +2708,8 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
> .desc = "Enhanced Virtualization Traps",
> .capability = ARM64_HAS_EVT,
> .type = ARM64_CPUCAP_SYSTEM_FEATURE,
> - .sys_reg = SYS_ID_AA64MMFR2_EL1,
> - .sign = FTR_UNSIGNED,
> - .field_pos = ID_AA64MMFR2_EL1_EVT_SHIFT,
> - .field_width = 4,
> - .min_field_value = ID_AA64MMFR2_EL1_EVT_IMP,
> .matches = has_cpuid_feature,
> + ARM64_CPUID_FIELDS(ID_AA64MMFR2_EL1, EVT, IMP)
> },
> {},
> };
Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>
next prev parent reply other threads:[~2023-07-19 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 19:45 [PATCH] arm64/cpufeature: Use ARM64_CPUID_FIELD() to match EVT Mark Brown
2023-07-19 14:53 ` Zenghui Yu [this message]
2023-07-27 12:22 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77417a3a-597f-b503-acc0-9c6afcaac511@linux.dev \
--to=zenghui.yu@linux.dev \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox