From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756982AbcIUKdK (ORCPT ); Wed, 21 Sep 2016 06:33:10 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:58601 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756599AbcIUKdH (ORCPT ); Wed, 21 Sep 2016 06:33:07 -0400 From: Arnd Bergmann To: Peter Ujfalusi Cc: vinod.koul@intel.com, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com Subject: Re: [PATCH v2 2/9] dmaengine: edma: Use enum for eDMA binding type (legacy vs TPCC) Date: Wed, 21 Sep 2016 12:31:52 +0200 Message-ID: <7753810.Z3F41qkFaI@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160921102637.24845-3-peter.ujfalusi@ti.com> References: <20160921102637.24845-1-peter.ujfalusi@ti.com> <20160921102637.24845-3-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:K9awmwIKLfgoEZ92fvggQvWRDm/KUwaDG72qnYpmIiTechnFttK GFoIXA9eiO5lZrgrZGjAq/jvFfcfRdYINmgaxbkTm5rIUCBd6Rcs5DBEtfho3XIOYAN5tr9 59LjAUOl3FwAnGHFBltI8i8Dlzzzyq2YORk/SoYQNww54ratu75Klzfk1GvCilWmDaBwuGG ny6sDVkzBtVGFggBJ1QKA== X-UI-Out-Filterresults: notjunk:1;V01:K0:2+FmyCiMn6g=:cb035+grUz77UqYSdECLe7 6TFEsYf1TcFKisJ8fiZAGinpKXHLGeFmn3jdlyZHLil9vMQUyp76iS59IXSx/6zUZTWqO0CId BtLZCruMOTkXDjsPDBQUxZ4tilxfoDWu+RmbDu/LfVqpINX7jRH28gYG3aULFlhwFDXSkaUGG RF1h1k3nFC8qYne1a4KKaenoBDLR8WKBGlBRVwMV9dZ+F6sMoiWEKFu7wL8GOCJ2OHz6hW/2S XIF5vyZ/WyXwu4t2DBK7CiZuM2jvxnXndf8tzZ0b7FNb3nQTFILkHuFgV8E0yTmKjbZofiYiv 32ZiDjhBM3FHXznWdA5y8x7YXn3EM/oGY4UBusP6iEEQtwIJUG1FxKCA1qxbF5FDaUGtbyeYU JDTb/c1AlMF8Aom9eVxVWY/LAH8VUL6114JW3QFoadDjTOTD+Ey7bFUmP4xKVKONPzSh0mc4l Fb/UrjccUaBPLyT3hJQIKz5Rn9Ow+EWpfV3CTY3sl7Hv1i5a1yZWMIpTE87bYF+ZhTTnvFV9S WxYiDX3N2Qho+01Zvck7hPpnpBAaHsSka7ln9TMv3L9TKMoRnixBN6O5m/bc0PhnmGAD5KLES GpET/c96Miw6WMyBcobbvr9NQnqYSgoTxw8JYgtX49XVXLo1R5JJKz5qdhyCykyjtBx9M25zN 4PM4+Z2kzU616LnGN/iWnZYVzj4B1vUxeSla4OdOgAllN3yBn8n6GD/fxDsvBAnrOChZLHc+S KvoyMrPCp7B4nH4X Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 21, 2016 1:26:30 PM CEST Peter Ujfalusi wrote: > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index c2098a4b4dcf..4c8818278fcc 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -261,8 +261,11 @@ static const struct edmacc_param dummy_paramset = { > .ccnt = 1, > }; > > -#define EDMA_BINDING_LEGACY 0 > -#define EDMA_BINDING_TPCC 1 > +enum edma_binding_type { > + EDMA_BINDING_LEGACY = 0, > + EDMA_BINDING_TPCC, > +}; > + > static const struct of_device_id edma_of_ids[] = { > { > .compatible = "ti,edma3", > @@ -2184,7 +2187,8 @@ static int edma_probe(struct platform_device *pdev) > const struct of_device_id *match; > > match = of_match_node(edma_of_ids, node); > - if (match && (u32)match->data == EDMA_BINDING_TPCC) > + if (match && > + (enum edma_binding_type)match->data == EDMA_BINDING_TPCC) > legacy_mode = false; > > info = edma_setup_info_from_dt(dev, legacy_mode); > -- > 2.10.0 > Are you sure this works on all architectures? IIRC the size of an enum is implementation defined, so this could still fail sometimes. I tend to use 'uintptr_t' for the cast instead. Arnd