From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B990828EA; Sat, 30 Nov 2024 10:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732963429; cv=none; b=I5QtOO7tFQW1cTnHwbQ3du0Jk3Gfu2XCXKbjlEbqchIPrerB9STsaim/Xw0e8Mg3j8jB+BGkZtgMR5KQlBWwcNm4YlEwrrXOt8uIKHE4BFz4hE5g/42haOSQCbZLf9qcy72vFmOUS3ewJe9x6bZwKekPGZFkjGcGp+IssE9LnwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732963429; c=relaxed/simple; bh=JsEWPPVS3Tn2e8xjl6YAbjJAZSsxj83BULLAIhY9qjI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EOxMaf9JOqfmSY6yczYaIa0MROOtMLyMSHA8AVCtlYFqPX4qnAUvRhgZSnIpZnbdZYkPxOclcOFrFYsottLHip1zLBJjaatO0dRl85dVOeEdxcmth7/2a4oYaP366bnJRVGQE0/S9MTu1E1EvZWxuV+t9YnggPgAMxVupDiYpk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ksIB8+CL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ksIB8+CL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5C15C4CECC; Sat, 30 Nov 2024 10:43:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732963429; bh=JsEWPPVS3Tn2e8xjl6YAbjJAZSsxj83BULLAIhY9qjI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ksIB8+CLfgOJmCAKII/NrcrxK0Luz+4zOV+sGaWBCznVGYDWJMeN6MorY/Gc3YwIv N1xiojF6jeWgltB/FVE3vXqgMEUjCNrrHRcwnJ+C+93tuGUcwCdFQ2jVXZQ0p/b4Y/ RQz5bA+DoTmCC8APzocCpkuphDOEWyHOg5cCIYwfaBBZRfJ//yPgcAhrI+vaT0Isnv 4wLAgg3xEvVOHlpU233V00mVT0tFkH9AkjFLzCSlr7PeS2SWKIjQ/GvOgnTD3xBJ8E ZHn615c85M4vqZXdbisWVEsY43v/Xy4MViPUMzUZL+Zk7F9aIqvwQ+uojS15fbQI8E YkZvCNyR20TIA== Message-ID: <7778fea9-c127-428d-9653-e66e84f23c98@kernel.org> Date: Sat, 30 Nov 2024 11:43:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/31] arm64: dts: qcom: ipq5018: move board clocks to ipq5018.dtsi file To: Dmitry Baryshkov Cc: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Leo Yan , Joseph Gates , Georgi Djakov , Shawn Guo , Stephan Gerhold , Zac Crosby , =?UTF-8?Q?Bastian_K=C3=B6cher?= , Andy Gross , Jeremy McNicoll , Rohit Agarwal , Melody Olvera , Bhupesh Sharma , cros-qcom-dts-watchers@chromium.org, Stephen Boyd , Rajendra Nayak , Martin Botka , Jonathan Marek , Vinod Koul , Tengfei Fan , Fenglin Wu , Neil Armstrong , Abel Vesa , Alexandru Marc Serdeliuc , Vladimir Zapolskiy , Sibi Sankar , Bryan O'Donoghue , Jun Nie , James Willcox , Max Chen , Vincent Knecht , Benjamin Li , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241130-fix-board-clocks-v2-0-b9a35858657e@linaro.org> <20241130-fix-board-clocks-v2-20-b9a35858657e@linaro.org> <83990b97-3f37-47f0-9cc6-fdaa730a8df1@linaro.org> <90418b49-5b19-4bef-b0cd-398bb562aa8c@kernel.org> <26lttxx7obu2oqvf4xnooqi3o7qwodhjzyjh4trjq5tlj2gzxs@uwihybmwbdid> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <26lttxx7obu2oqvf4xnooqi3o7qwodhjzyjh4trjq5tlj2gzxs@uwihybmwbdid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/11/2024 11:26, Dmitry Baryshkov wrote: > On Sat, Nov 30, 2024 at 11:00:32AM +0100, Krzysztof Kozlowski wrote: >> On 30/11/2024 10:57, Dmitry Baryshkov wrote: >>> On Sat, Nov 30, 2024 at 10:29:38AM +0100, Krzysztof Kozlowski wrote: >>>> On 30/11/2024 02:44, Dmitry Baryshkov wrote: >>>>> IPQ5018 is one of the platforms where board-level clocks (XO, sleep) >>>>> definitions are split between the SoC dtsi file and the board file. >>>>> This is not optimal, as the clocks are a part of the SoC + PMICs design. >>>>> Frequencies are common for the whole set of devices using the same SoC. >>>>> Remove the split and move frequencies to the SoC DTSI file. >>>>> >>>>> Suggested-by: Bjorn Andersson >>>>> Signed-off-by: Dmitry Baryshkov >>>> >>>> This contradicts DTS coding style and all my existing review. Obviously >>>> that's a NAK from me. If you want to merge this patch, please kindly >>>> carry my formal objection for this and all following "move board clocks" >>>> patches: >>>> >>>> Nacked-by: Krzysztof Kozlowski >>> >>> I'd kindly ask Bjorn to chime in as a platform maintainer. >> >> >> To change my NAK? NAK is still a NAK. We discussed it many, many times >> already. We have coding style for this explicitly mentioning this case. >> Could not be more specific... plus all my reviews for Qualcomm, NXP, TI, >> ST and other platforms. I would be quite unpredictable or unfair if I >> gave here some sort of exception while expecting different code from >> other platforms. >> >> Please carry my NAK. > > Of course. I didn't mean to drop your tag or your objection. > > BTW, would it be possible for you to clarify the policy on external > references? I mean, is it fine for DTSI to reference a label which is > not defined within that file or within one of the files that it includes? It is fine, you have plenty of such examples of shared components like some audio blocks or PMICs. All Qualcomm PMICs DTSI (e.g. arch/arm64/boot/dts/qcom/pmi632.dtsi ) reference them. Chromebooks are even "worse" here: arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi Nothing gets included there but hundred of phandles! Are you planning to "fix" these as well? These are just Qualcomm, but same cases are everywhere else. But *that's not even important* because I do not suggest to move clocks to DTSI. I suggest - and was almost always suggesting as best compromise - to follow DTS coding style by doing opposite of what this patch is doing. That's why I NAKed this and following patches, except last two which are different. Best regards, Krzysztof