From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012070.outbound.protection.outlook.com [52.101.48.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AAD819343E for ; Tue, 24 Mar 2026 18:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.70 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774378772; cv=fail; b=JWhNfvVnfcadkM1OTxSP4p6tAyiM5Kdt/nS8bh8D0uwF91CfJNfEGl9yaAboaQTkYJgl0rKd6AwT5YutGbk/n8CaJ976npOojrLqhfBo8KyPgx+uL25g+syaRYP2A5xbTSysKDoo5taJYSUvWOERzCUX6TcXe10GSLPrYCIWlYM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774378772; c=relaxed/simple; bh=0WYHzJFCJTCRSxNlmY3gEm6aUqG5kGRIAia2XHhfwDQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=nfpBVjbH3q+qBsZQmJ0t1eoi+1A8i8nCYGB1CNqcuB5NEmXCkIYRbef4RznCpVNOqUD/6Jmr5J2KEZH62ndLDvwYUwIAfkkVxJQIglDOYHiGgWF0byoNvuqH5kk3I+dBWbvjTZy/v31NtqIPA3e63y1a8vwhM/yjr0yptOTV4dM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KUOQaLBo; arc=fail smtp.client-ip=52.101.48.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KUOQaLBo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LGtV55zwCufXZk3kdqAfdEdRG2qdggMRa5nDVxpLjRE+LavknMg2mLElWJJ6TmBwR2qZWKjUi2YTeICW5Q8pw12mQ46LYI2bWP/WlKoIljJZCLG6Gw02lhzVU4zYguesNBK/fgGkGwEWbI+hj9Mol55UspiHpfKWMnDex528b4m6LXul6kOEZNPnUkXmuhQtmAMckZNJ4xhXj7mQ2NDdXfp2TOiwVtPJx0yo89YOViQLgNTbP5ab/lNQNzodpYQ2tEIjNoPxF/sas0Py9rmJkPlFWaO34r4nYMoWcW6kdOBIBHa6L8ByLtrpDM7dIDSg7FY937l3Qc60Crf6Vu1eHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zrnd7A/VMLZwxKx/SJZYM2In4bkAXC76Fm53P/39FjM=; b=CYlgyEUukXDjfnhGenTgm14+j1LX8WckAE22Du+mMCRE9D4W5hdaAsodY0/zUF7EPKNMd9h2mPgXYOvehUjtCFJcRbNZoQd9/W1LunMZAJBy13VUMS/hK8cx2Ppy/dpdZWgBj+aVOzF+XDl2CqNDg9JJuWVTkHn8m6iC5cbD4cbn9HhzPo35VVACuQpjhPk0WEHUeF+Q0h7lcLRI9Pi17M0Xs7dOsGBvd3I7BVFklkgXudy2z50cR1ypR1PsRYbTsCZz1WeztxT7P0ebleoniQpsIfCzYirpNwUho4RdxCuoT3JxkJCXYVvqwX5UkSvRTMUpMHkHTydorpN/DODKog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zrnd7A/VMLZwxKx/SJZYM2In4bkAXC76Fm53P/39FjM=; b=KUOQaLBo5edK44k3m4qCQYoI1eIc6wfvkqzsE7gU6u7CoLqiStBgG9E5U0ideBRrepnKYDTzjj4c8/j2vC2G3+bk+ZoWxpS0POHvKAV23Apb7Ga+i3RsLh0UKZoSun3PKibL9F7uDcZatu+VkBToKaffnWDx98UzFEzu09yfntg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN9PR12MB5259.namprd12.prod.outlook.com (2603:10b6:408:100::17) by DM6PR12MB4220.namprd12.prod.outlook.com (2603:10b6:5:21d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Tue, 24 Mar 2026 18:59:26 +0000 Received: from BN9PR12MB5259.namprd12.prod.outlook.com ([fe80::122c:cca7:c2b3:90ed]) by BN9PR12MB5259.namprd12.prod.outlook.com ([fe80::122c:cca7:c2b3:90ed%3]) with mapi id 15.20.9745.019; Tue, 24 Mar 2026 18:59:26 +0000 Message-ID: <77c3208e-6ee9-477d-b363-0baaea584ef7@amd.com> Date: Wed, 25 Mar 2026 00:29:19 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/migrate: rename PAGE_ migration flags to FOLIO_ To: "David Hildenbrand (Arm)" , Andrew Morton Cc: willy@infradead.org, Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260324114720.864478-2-shivankg@amd.com> Content-Language: en-US From: "Garg, Shivank" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0119.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:96::9) To BN9PR12MB5259.namprd12.prod.outlook.com (2603:10b6:408:100::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN9PR12MB5259:EE_|DM6PR12MB4220:EE_ X-MS-Office365-Filtering-Correlation-Id: 319cc131-9640-42f4-f12d-08de89d77815 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|18002099003|56012099003|22082099003|7053199007; X-Microsoft-Antispam-Message-Info: ljmv+nzwkyMBe3O0onEOAfbYeeZYtzeu5wiBTCYDNYWUl1MnM0tCnCM+HTEjsu5pQUpnNot44PHcuhHaJD0ZeqRSWxVKEk1wUBe3DWJdUiTCwtZoXp38V8ovt1gqN5FBv9URRiSJjUsUjXOsjiTFl4f/l+PvFrGohO5VTFMErSuIzC9gHekrBwBRXoC8+d+Ch5GqrEuaFgagA/UJQxfURMdd0LRr/M3bVl9HwOhOFQhYeaoNKDylvDZk2QIK3tBw0qKFzqQiqKcpbJy/8jJBO8bXXNY+7Yynow6qe9gqBbR2pEsTD7+hm7Za3MY3v9ZaNaCD4+agetjA6V2UZGMWp3NBlGbLIVLnGwkiMbM41RUbmlzUnYRwjArAVkOlil6tf0aUFeAiBsPkd7hF74/u3pImJds+UfOBRUWdOXaO4QBJocTLLAOvwiq0BrxmJFWYXutWvjDvbEIqxIe8wYGQurDaxlr30z7k3l3nkp8veCUn+WPjHzFOm1BnATB1n9Sbfhw+UZjTZXpOIz0tgD99y3qhGMvfpI2GSSztwoHQuHnEu0dVA8mymSeU0IpSJUr++aQahSoW72ftNrR6wCO55HzmF5w8CfMRdsu2F1ehTAHSkgtzLG4urnLChoJHYmjdfuPy0WZVCgZ91qeOizjQT+70Z43f3djtVJFJT/kiIQghYa5Kbp2Yaqqx+FaML9yhw+TIW787QkL5pxJLpWAV9dFQQ51XvfT2fIAh37WEgjUklZZv9YSIrftX5lJf+ua0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5259.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(18002099003)(56012099003)(22082099003)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djBRZTlDcFpubUkxU2orbGx4anNaRDRsU1VKTXBqNnlhWnY0ajhWTVJ6RFNv?= =?utf-8?B?WXlHcXZiVVdwMmtoTUdHd3ZDWWNPZzFINk1WRHBUV1B1bzMxZ1U4WlZOdnYr?= =?utf-8?B?V01ab0xYbjRjM0tRUW9CMmVjZFVYeVFpQjBsMEZGVnNsZm9DZ0RLVzl0SlQv?= =?utf-8?B?cEdkbVoxaTdmTWlJckFFb2ZiOU9Fam5BTzJiR0JteFZaRXpKVG5NN3RiY2dt?= =?utf-8?B?RjVkNmdRSXZQRmZVeGh6T0lnU1hJSnRGSzZOTVJuVm9vTDdSekgvK0EvemtN?= =?utf-8?B?c1VTTlg4eWZoN0tjZldhWk9aOFUrSGUrS0k3eElhc2lVM1FHeHhFd2dmY3ZV?= =?utf-8?B?QTkvTWwzM0dwUmJ0UEdNbnRhZUtpZ3owTVFTYmtRUlorZ1VkbVZFWWlMd2J5?= =?utf-8?B?TG9CV09zTUdrSmsyWXExRysvUU1sV1NqN3BwUEUzdFN4SEVHZ0Nsa0hYRFBs?= =?utf-8?B?MjF3Titrc0JWQVdXbXB6SkNPUnJKV2ZrYU1GbjdNNTRJUGgybDJnSkxTbWFS?= =?utf-8?B?aVpmQVZBREFkRUcvUm11THRWK25BU0dyUGJnWEJld1dYU1NqQ091SGkrWlpV?= =?utf-8?B?VVdBdGxwTEhlUlFBcTIwc0Q4M010amlHNklSL29QT1M4bXRGVTVqTE5pVXlY?= =?utf-8?B?NFZxN1VIamx3aDYyWmFPN0dXYnR4NVhweXduLzZFck1reGQvbC94RzluR0ZR?= =?utf-8?B?K0d3M21tckQvZ2RnZVN1Z0NtMXkvZVZOSHdpT0lZS2gvUHpzdWE0aDdKbFdP?= =?utf-8?B?dXJHb2krMENLWUo5TFlSVWNFZTZzbEhjdWdpVFhGYXRvYm5KTXFlNFdBQ2tK?= =?utf-8?B?M2ZKd0pUOVBGU1AzWGhuVlFOekxsSC9UQ25vcXJvdCtOQWx1MWdGU2hLcHNN?= =?utf-8?B?N2ZvRnBXN2FvRkZjNHFJVEdqTmdLYnZ3M2RJN0d4cXhJeGQ2aXVsU1ZnZTc1?= =?utf-8?B?N1k0OEM5bjNMdjk4QXUxWmQyNEVFdStKSnVmM3FSU0gwYm5lOTlwZm9ZUHRP?= =?utf-8?B?NTVqaHRzZTA4a0t1Q2Rya1liUWM4KytpTUpPc2tRUWZ5dWptRjRlMXAzeVZq?= =?utf-8?B?dm1TdHFnZkFWQmJ4SlFhb3FOdXBtUSt5YWJUQVJjNGxndDJLT3FtQTdkQW1l?= =?utf-8?B?WHh5dk9LM2YxaitzT1ZGL3p6cm1ja2JtcG0zQTRRWHNWUVBhMldiaTRUZFpl?= =?utf-8?B?bUVHdCs4Qk1ROFBaTEVuUG1pZEhrbkowdzN2eWdMQTZkbHF0Wnd0WGxVMytU?= =?utf-8?B?OGMxcGtOL1VLQnRZeTFNcml5YzFVNXN3by9PTktqbFFiVzJrTHQwSG9zcUFz?= =?utf-8?B?MWJZZGQ4eGoxalU2akVKMVdVdTE4VFpiTWF4SG56ZXY4VE82cWo2UU5aLzJr?= =?utf-8?B?WGsyVXNzK1JEcmlacXVOOUwxM09PNnl5Tk5EVlh4cThuU3NSL05aOGhDa2NW?= =?utf-8?B?MEVZdnh1L1I5YnFxbS9XK09aUUN1MlFRT01Ob2I5MFdyMXg4ZWpMSDh4bS9y?= =?utf-8?B?M3FpTVNLZVpMOHVxeGRSZXBrci81bytBUWpYcHcyMzltNzhBTVJEVklMcUZ1?= =?utf-8?B?ZlMvQi9PYlI5dk9DMUdqU3VoQUxoWkl5QlNWbEtFL05oVkhoRU82Wlp6eUhP?= =?utf-8?B?VHovdFZyT09CQnFzYk9rMTk5SHZBa0NzdjM5cDRCalpPOUloZFhrcTdNbksv?= =?utf-8?B?MklpY29kYXVqSEkvUjVUT3FaRjl6QUEzYWNFZStuQkVhY0sxOTBnMFNnUnJ6?= =?utf-8?B?NXBNYk1LVG81TWUrMlUwVDg2WGVlMEFqRkZEZlVwelpNVlVlTEN6T0hrTzd6?= =?utf-8?B?UVU2MSszT2NkNUk5Q2xCai9TdnJPRmtWNDlHbzhKWng1UUQ4dGF4K0p3cDBP?= =?utf-8?B?bnpVYVFKZ2ZGT3haVVBYQ1NmKzRlUGZVMXdtalo1dzVQYzMvcUhDYWtiZ1FT?= =?utf-8?B?UU9RenZ0L1E3WmxiTFhCU1poUkNjU3NyTGRUYVlaUHVPWDBEbFpKaG9VdHJJ?= =?utf-8?B?NUJrbDRTL0x4R05HL3B6NGwxb1lVM2lQeFVlNmNFSmIzMzFkajRNLzhvSk93?= =?utf-8?B?RkRudi9ZTkh1WW04cWxaeUJhdjJFNjdpdW9PMm9manBDY3B0b2RXNndMV3dK?= =?utf-8?B?cXJCVWZKWHFMWjhhZ0ZhVnpmMVRRaGRMUEFyeWw3ay9QY2JsRnlhaWV4K2d6?= =?utf-8?B?OEFVUGlOaEZoNVlKMW9oZGZnbG1zb3JuVUdEZmd1V0g5Y3BRMlV0djIyQlVx?= =?utf-8?B?bnRxQW5BU3RnM0tWbEJSSmRyUmlvak9vQ29lc056ZG44eUhRYVQ1WFA3Y0d1?= =?utf-8?B?MzczRkpkSi9BNy9YT3J6U3RSREhQaWFjTVRWQkFTQWcycHJ4cDhkdz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 319cc131-9640-42f4-f12d-08de89d77815 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5259.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2026 18:59:26.0312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BzQKD7vmHPqtj40ksL9y41nqhNamcNqEvZj6Cc3TxK8T3CbiLUCSDZlQb3MiYZiIpu8nsUpibW+CEb/bL7iegw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4220 On 3/24/2026 6:01 PM, David Hildenbrand (Arm) wrote: > On 3/24/26 12:47, Shivank Garg wrote: >> These flags only track folio-specific state during migration and are >> not used for movable_ops pages. Rename the enum values and the >> old_page_state variable to match. >> >> No functional change. >> >> Suggested-by: David Hildenbrand >> Signed-off-by: Shivank Garg >> --- >> >> Applies cleanly on mm-new (02b045682c74). >> >> v1: https://lore.kernel.org/all/20260323141935.389232-3-shivankg@amd.com >> >> v2: >> - Rename FOLIO_MF_* to FOLIO_*, per feedback from Willy. >> >> mm/migrate.c | 46 +++++++++++++++++++++++----------------------- >> 1 file changed, 23 insertions(+), 23 deletions(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index 05cb408846f2..7dd6c2f2e1ef 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -1135,26 +1135,26 @@ static int move_to_new_folio(struct folio *dst, struct folio *src, >> * This is safe because nobody is using it except us. >> */ >> enum { >> - PAGE_WAS_MAPPED = BIT(0), >> - PAGE_WAS_MLOCKED = BIT(1), >> - PAGE_OLD_STATES = PAGE_WAS_MAPPED | PAGE_WAS_MLOCKED, >> + FOLIO_WAS_MAPPED = BIT(0), >> + FOLIO_WAS_MLOCKED = BIT(1), >> + FOLIO_OLD_STATES = FOLIO_WAS_MAPPED | FOLIO_WAS_MLOCKED, >> }; >> >> static void __migrate_folio_record(struct folio *dst, >> - int old_page_state, >> + int old_folio_state, >> struct anon_vma *anon_vma) >> { > > While at it, you could just use two tabs to indent the second parameter > line. > Sure, will fix this. > > >> - dst->private = (void *)anon_vma + old_page_state; >> + dst->private = (void *)anon_vma + old_folio_state; >> } >> >> static void __migrate_folio_extract(struct folio *dst, >> - int *old_page_state, >> + int *old_folio_state, >> struct anon_vma **anon_vmap) >> { > > Same here. > > > Thanks! > > Acked-by: David Hildenbrand (Arm) > Thanks, Shivank