Re: [PATCH v2 07/10] irqdomain: Allow giving name suffix for domain

Thomas Gleixner
2024-06-03T10:20:44Z

On Fri, May 24 2024 at 11:18, Matti Vaittinen wrote:
> When multiple IRQ domains are created from same device-tree node they

s/IRQ/interrupt/

Also most of your sentences lack a substantial amount of articles.

> will get same name based on the device-tree path. This will cause a
> naming collision in debugFS when IRQ domain specific entries are
> created.
>
> One use-case for being able to create multiple IRQ domains / single
> device node is using regmap-IRQ controller code for devices which
> provide more than one physical IRQ.

This does not make sense. Why do you need multiple interrupt domains if
there is more than one physical interrupt?

> It seems much cleaner to instantiate

'It seems' is not a technical argument.

> own regmap-IRQ controller for each parent IRQ because most of the regmap
> IRQ properties are really specific to parent IRQ.

Now you start talking about parent interrupts. Can you please make your
mind up and concisely explain what this is about?

> -struct irq_domain *irq_domain_create_legacy(struct fwnode_handle *fwnode,
> +struct irq_domain *irq_domain_create_legacy_named(struct fwnode_handle *fwnode,
> unsigned int size,
> unsigned int first_irq,
> irq_hw_number_t first_hwirq,
> const struct irq_domain_ops *ops,
> - void *host_data)
> + void *host_data, const char *name_suffix)
> {
> struct irq_domain *domain;
>
> - domain = __irq_domain_add(fwnode, first_hwirq + size, first_hwirq + size, 0, ops, host_data);
> + domain = __irq_domain_add(fwnode, first_hwirq + size, first_hwirq + size,
> + 0, ops, host_data, name_suffix);
> if (domain)
> irq_domain_associate_many(domain, first_irq, first_hwirq, size);
>
> return domain;
> }
> +EXPORT_SYMBOL_GPL(irq_domain_create_legacy_named);

What for? This new stuff is not going to be used for legacy setups with
hard coded Linux interrupt numbers. So there is no point to add a
function plus an export which is never used.

Thanks,

tglx