From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349C2C433EF for ; Fri, 17 Sep 2021 07:37:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A27661130 for ; Fri, 17 Sep 2021 07:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241247AbhIQHiu (ORCPT ); Fri, 17 Sep 2021 03:38:50 -0400 Received: from mga14.intel.com ([192.55.52.115]:63016 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241229AbhIQHir (ORCPT ); Fri, 17 Sep 2021 03:38:47 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10109"; a="222402244" X-IronPort-AV: E=Sophos;i="5.85,300,1624345200"; d="scan'208";a="222402244" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 00:37:24 -0700 X-IronPort-AV: E=Sophos;i="5.85,300,1624345200"; d="scan'208";a="554499884" Received: from shettiar-mobl2.ger.corp.intel.com (HELO [10.213.243.199]) ([10.213.243.199]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2021 00:37:22 -0700 Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: use strscpy() to avoid buffer overrun To: Tim Gardner , intel-gfx@lists.freedesktop.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20210916122649.12691-1-tim.gardner@canonical.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <77c6c991-b7b4-0362-63ca-17a801187f7a@linux.intel.com> Date: Fri, 17 Sep 2021 08:37:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210916122649.12691-1-tim.gardner@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/2021 13:26, Tim Gardner wrote: > In capture_vma() Coverity complains of a possible buffer overrun. Even > though this is a static function where all call sites can be checked, > limiting the copy length could save some future grief. > > CID 93300 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) > 4. fixed_size_dest: You might overrun the 16-character fixed-size string c->name > by copying name without checking the length. > 5. parameter_as_source: Note: This defect has an elevated risk because the > source argument is a parameter of the current function. > 1326 strcpy(c->name, name); > > Fix any possible overflows by using strscpy() which guarantees NULL termination. > > Also correct 2 other strcpy() call sites with the same potential for Coverity > warnings or overruns. > > v2 - Change $SUBJECT from "drm/i915: zero fill vma name buffer" > Use strscpy() instead of strncpy(). Its a much simpler change. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: David Airlie > Cc: Daniel Vetter > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 9cf6ac575de1..7f246f51959d 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1015,7 +1015,7 @@ i915_vma_coredump_create(const struct intel_gt *gt, > return NULL; > } > > - strcpy(dst->name, name); > + strscpy(dst->name, name, sizeof(dst->name)); > dst->next = NULL; > > dst->gtt_offset = vma->node.start; > @@ -1279,7 +1279,7 @@ static bool record_context(struct i915_gem_context_coredump *e, > rcu_read_lock(); > task = pid_task(ctx->pid, PIDTYPE_PID); > if (task) { > - strcpy(e->comm, task->comm); > + strscpy(e->comm, task->comm, sizeof(e->comm)); > e->pid = task->pid; > } > rcu_read_unlock(); > @@ -1323,7 +1323,7 @@ capture_vma(struct intel_engine_capture_vma *next, > return next; > } > > - strcpy(c->name, name); > + strscpy(c->name, name, sizeof(c->name)); > c->vma = vma; /* reference held while active */ > > c->next = next; > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko