From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D41CC61D97 for ; Wed, 22 Nov 2023 14:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344040AbjKVOwq (ORCPT ); Wed, 22 Nov 2023 09:52:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231481AbjKVOwo (ORCPT ); Wed, 22 Nov 2023 09:52:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA602DD for ; Wed, 22 Nov 2023 06:52:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3537C433C8; Wed, 22 Nov 2023 14:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700664760; bh=sAcyOaQD3H8yNNyICEEcQesIVItkS+W3nQU7LOMsA5Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=H2nLHfrlVrecaRMxljeGrGPPA1/Bs/RYZ9Ev2x/KsNSFbFCgd/Qa2eOI1Ow7fQDFv 2HslTgqlcfn1snthG3a2Yd2eXCyOo8jw02pp3VrnMIvRNPuZovk5YjLdStnmd6c/TT 02mXMVlEVH055S1KG/3Yrj+Mk47dUePHMWbXZka/pWJULz2U5vPAfQveM9rBrtOBNg zegujGhydRKuiORCgoNcobzs4mvum0pUjynIpc8upA+9Zpr+Qon06kn69aswrJSbxg vFmyNhsFD/hQvgpXgVGthf+Vk+si05oI3aSM0UGm118ezb3EP3NoEa35IX9IMdU9eM YWRLWvt1a1G7A== Message-ID: <77f39971-6d8a-4e1a-b7e6-bffb5fbf74db@kernel.org> Date: Wed, 22 Nov 2023 16:52:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/2] dt-bindings: interconnect: Add Qualcomm X1E80100 SoC Content-Language: en-US To: Sibi Sankar , andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: agross@kernel.org, conor+dt@kernel.org, quic_rjendra@quicinc.com, abel.vesa@linaro.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_tsoni@quicinc.com, neil.armstrong@linaro.org References: <20231117103035.25848-1-quic_sibis@quicinc.com> <20231117103035.25848-2-quic_sibis@quicinc.com> From: Georgi Djakov In-Reply-To: <20231117103035.25848-2-quic_sibis@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sibi, On 17.11.23 12:30, Sibi Sankar wrote: > From: Rajendra Nayak > > The Qualcomm X1E80100 SoC has several bus fabrics that could be controlled > and tuned dynamically according to the bandwidth demand. > > Co-developed-by: Abel Vesa > Signed-off-by: Abel Vesa > Signed-off-by: Rajendra Nayak > Co-developed-by: Sibi Sankar > Signed-off-by: Sibi Sankar > Reviewed-by: Krzysztof Kozlowski > --- > > v2: > * Update the part number from sc8380xp to x1e80100. > * Fixup required property ordering [Krzysztof] > * Pickup Rbs. > > .../interconnect/qcom,x1e80100-rpmh.yaml | 83 +++++++ > .../interconnect/qcom,x1e80100-rpmh.h | 207 ++++++++++++++++++ > 2 files changed, 290 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,x1e80100-rpmh.yaml > create mode 100644 include/dt-bindings/interconnect/qcom,x1e80100-rpmh.h [..] > +#define MASTER_AV1_ENC 0 > +#define MASTER_CAMNOC_HF 1 > +#define MASTER_CAMNOC_ICP 2 > +#define MASTER_CAMNOC_SF 3 > +#define MASTER_EVA 4 > +#define MASTER_MDP 5 > +#define MASTER_VIDEO 6 > +#define MASTER_VIDEO_CV_PROC 7 > +#define MASTER_VIDEO_V_PROC 8 > +#define MASTER_CNOC_MNOC_CFG 9 > +#define SLAVE_MNOC_HF_MEM_NOC 10 > +#define SLAVE_MNOC_SF_MEM_NOC 11 > +#define SLAVE_SERVICE_MNOC 12 > +#define MASTER_MDP_DISP 13 > +#define SLAVE_MNOC_HF_MEM_NOC_DISP 14 > + > +#define MASTER_CDSP_PROC 0 > +#define SLAVE_CDSP_MEM_NOC 1 > + > +#define MASTER_PCIE_NORTH 0 > +#define MASTER_PCIE_SOUTH 0 This duplicate index looks like a typo? > +#define SLAVE_ANOC_PCIE_GEM_NOC 3 > +#define MASTER_PCIE_NORTH_PCIE 4 > +#define MASTER_PCIE_SOUTH_PCIE 5 > +#define SLAVE_ANOC_PCIE_GEM_NOC_PCIE 6 [..] Thanks, Georgi