From: Keith Owens <kaos@sgi.com>
To: Bernardo Innocenti <bernie@codewiz.org>
Cc: Jordan Crouse <jordan.crouse@amd.com>,
kdb@oss.sgi.com, linux-kernel@vger.kernel.org, devel@laptop.org
Subject: Re: kdb: add rdmsr and wrmsr commands for i386
Date: Thu, 17 May 2007 16:39:35 +1000 [thread overview]
Message-ID: <7803.1179383975@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Thu, 17 May 2007 02:36:21 -0400." <464BF7E5.4080105@codewiz.org>
Bernardo Innocenti (on Thu, 17 May 2007 02:36:21 -0400) wrote:
>Keith Owens wrote:
>
>> Before using MSR, you must first check that the cpu supports the
>> instruction, rd/wrmsr cause an oops on 486 or earlier. Also using an
>> invalid msr number causes an oops, so use rd/wrmsr_safe().
>
>I didn't bother implementing those checks because kdb recovers
>nicely from GPF anyway.
Yes and no. Yes, kdb will recover from a GPF. No, because if the
system was already running correctly (i.e. manual entry into kdb), then
taking a GPF and not recovering will flag the rest of the system as
corrupt and can kill a running system. I try to avoid adding spurious
system corruption.
>It's the valid MSR writes that could
>cause unrecoveable problems! :)
Tell me about it :-(
prev parent reply other threads:[~2007-05-17 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46494B99.2030502@codewiz.org>
[not found] ` <20070515145133.GE27984@cosmic.amd.com>
2007-05-16 3:03 ` kdb: add rdmsr and wrmsr commands for i386 Bernardo Innocenti
2007-05-17 6:22 ` Keith Owens
2007-05-17 6:36 ` Bernardo Innocenti
2007-05-17 6:39 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7803.1179383975@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=bernie@codewiz.org \
--cc=devel@laptop.org \
--cc=jordan.crouse@amd.com \
--cc=kdb@oss.sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox