From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF911C47255 for ; Tue, 12 May 2020 03:16:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A17122071A for ; Tue, 12 May 2020 03:16:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F89vVYAi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728679AbgELDQT (ORCPT ); Mon, 11 May 2020 23:16:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728564AbgELDQS (ORCPT ); Mon, 11 May 2020 23:16:18 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D13C8C061A0E; Mon, 11 May 2020 20:16:18 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id q24so8705477pjd.1; Mon, 11 May 2020 20:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TMTWD2AEyTJvNKmDbcm7IQuSKi2QY0etChP/BpKXe0Q=; b=F89vVYAiesAXDj1ZMHZrzG6bGF08aVe6u9c9mIiR2uqM6D41RNRi0BccSiG7dj/PVT yhh8VhuzouUV7xbY2PPE9/BHwh1ehR7NBsx86mhbds96z9M4gjC4I20Z1vHAHX4LbfOn 2zkXxI1u/KaZKrOYqUZZGwX4Z5ZkAOtRxUzM5a65fi8KR5VUOMCqTYi1uHg5+D5obpRv L/CIbeKOzuVrir/s6gRFePiAIkd/ohblJ2OJtQXTzay9RZ8/MlKElE1PVONJycnTFlWQ Gu+Ph+KYm5VDHUl9ehIT1BXZ0BkOoG/OiZHfnEpBBh5vObyttX5d57Am4+AeJwkmMrzu 8LdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TMTWD2AEyTJvNKmDbcm7IQuSKi2QY0etChP/BpKXe0Q=; b=O4KTl6fKtzr3IThvj4CC5efihExg0flhjcLplUckfU/mjpR+T5d1kvrmtEFHRXs3B5 nf93s/u8UtaNDyyxZa9ui/Xxq8aPZeOFO5h6t/x5X9yLxjG/8QM6EshNTYmw/iZe6CMq cNDmXlICffQJmwmgx1SrZUYvcFhHApq4EW7yutFqfPchT7UTJL7r/uYTwLA8Upy/Zp9F wIHCwcCz+nKztmo+8RzIetO8YiDdnntU8DgmoF8ts+4xfnI0GLLQN+SZHCWSLjV+ritz FhPOykaSCFQ//HGtpC3hh1oKllFoZqS3dkhFwviJPInb2fP4R5Bu5d+VfY+HmsZ/UXm5 iYhQ== X-Gm-Message-State: AGi0PubEwJyoPMWLWFoXPKmHwe18G8hhYRaxymoOrdsqpbS81IiTQgH7 82aW+DHWL749M7DuAX4SZTKMkQd3 X-Google-Smtp-Source: APiQypIjkdBluToqMWAYZfwoXkyHBB3/YZZNVujMHtl3WhuyPDh6qm36TvXC2Cr3muURSDTXAD/VBw== X-Received: by 2002:a17:90b:4c88:: with SMTP id my8mr27001635pjb.199.1589253377745; Mon, 11 May 2020 20:16:17 -0700 (PDT) Received: from [10.230.188.43] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id v9sm11206720pju.3.2020.05.11.20.16.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2020 20:16:16 -0700 (PDT) Subject: Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting To: Doug Berger , "David S. Miller" Cc: Andrew Lunn , Heiner Kallweit , Russell King , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1589243050-18217-1-git-send-email-opendmb@gmail.com> <1589243050-18217-2-git-send-email-opendmb@gmail.com> From: Florian Fainelli Message-ID: <7810cf09-0dac-638b-6ec0-e8a5002ae7bf@gmail.com> Date: Mon, 11 May 2020 20:16:15 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <1589243050-18217-2-git-send-email-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/2020 5:24 PM, Doug Berger wrote: > A comment in uapi/linux/ethtool.h states "Drivers should reject a > non-zero setting of @autoneg when autoneogotiation is disabled (or > not supported) for the link". > > That check should be added to phy_validate_pause() to consolidate > the code where possible. > > Fixes: 22b7d29926b5 ("net: ethernet: Add helper to determine if pause configuration is supported") > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian