From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169FAC61D85 for ; Fri, 24 Nov 2023 02:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbjKXChm (ORCPT ); Thu, 23 Nov 2023 21:37:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjKXChk (ORCPT ); Thu, 23 Nov 2023 21:37:40 -0500 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [IPv6:2001:41d0:1004:224b::ba]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7008C11F for ; Thu, 23 Nov 2023 18:37:46 -0800 (PST) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700793464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jTrWgPTmhL+pfMdbtv8oZ0hXd6mtQwXeT2Ul7xLq8pM=; b=rxOvgmZby8bs+M3u65ZmeIsiqbfYUlsFgcTKzcFbx4s3TWRBH3/Fy2bflm9Ge7uAnlhMg7 NRSN9f6J3N1rxV/qkm6ezPqAmqnkBD83WnvIhOO9PFpHKRVf5fljDi2N+FXichstd1OsF7 OsnIgQ0FQNEpn6Pdym/EEmcM2fMpV7o= Mime-Version: 1.0 Subject: Re: [PATCH] fs/Kconfig: Make hugetlbfs a menuconfig X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Fri, 24 Nov 2023 10:37:06 +0800 Cc: Peter Xu , LKML , Linux-MM , Andrew Morton , Mike Kravetz , Muchun Song , linux-fsdevel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <7830CCC4-B1E4-4CCD-B96B-61744FAF2C79@linux.dev> References: <20231123223929.1059375-1-peterx@redhat.com> To: Randy Dunlap , Peter Xu X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Nov 24, 2023, at 08:19, Randy Dunlap wrote: > > BTW: > > On 11/23/23 14:39, Peter Xu wrote: >> Hugetlb vmemmap default option (HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON) >> is a sub-option to hugetlbfs, but it shows in the same level as hugetlbfs >> itself, under "Pesudo filesystems". >> Make the vmemmap option a sub-option to hugetlbfs, by changing hugetlbfs >> into a menuconfig. >> >> Cc: Mike Kravetz >> Cc: Muchun Song >> Cc: linux-fsdevel@vger.kernel.org >> Signed-off-by: Peter Xu >> --- >> fs/Kconfig | 20 +++++++++++--------- >> 1 file changed, 11 insertions(+), 9 deletions(-) >> >> diff --git a/fs/Kconfig b/fs/Kconfig >> index fd1f655b4f1f..8636198a8689 100644 >> --- a/fs/Kconfig >> +++ b/fs/Kconfig >> @@ -254,7 +254,7 @@ config TMPFS_QUOTA >> config ARCH_SUPPORTS_HUGETLBFS >> def_bool n >> >> -config HUGETLBFS >> +menuconfig HUGETLBFS >> bool "HugeTLB file system support" >> depends on X86 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN >> depends on (SYSFS || SYSCTL) >> @@ -266,14 +266,7 @@ config HUGETLBFS >> >> If unsure, say N. >> >> -config HUGETLB_PAGE >> - def_bool HUGETLBFS >> - >> -config HUGETLB_PAGE_OPTIMIZE_VMEMMAP >> - def_bool HUGETLB_PAGE >> - depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP >> - depends on SPARSEMEM_VMEMMAP >> - >> +if HUGETLBFS >> config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON >> bool "HugeTLB Vmemmap Optimization (HVO) defaults to on" >> default n >> @@ -282,6 +275,15 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON >> The HugeTLB VmemmapvOptimization (HVO) defaults to off. Say Y here to > > Is this small 'v' ^ a typo? Yes. Thanks for pointing it out. Although it is not related to this patch, but it will be nice for me to carry this tiny typo fix. Hi, Peter, would you like help me do this? Thanks.