From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C62024C07A for ; Tue, 20 May 2025 16:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747757849; cv=none; b=j4A6zeYHO29ZwF4FrElvM4DudCMrBvTJ4cJZf4Uwv9neW4M7nyrdJh/ZSMo+yrV9uGDs8S+5Uglns39wH/WfxRZaOiPWMxv+87nxY8IiohMvgvgSYnT3tN6EQhjpiJQ4o5zZNr+jkreuhVfTY2L3kftobwKZelx9m5rsV3LlrAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747757849; c=relaxed/simple; bh=eo2ll8aZP6fB5Qmh625oasg94Q1ESOBYvDMW/Yk3xZ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JqbOD4hJAAc5ho6tXTCZN7zovBzPeLUe9p6tOZ+XeBFrRrEYbFD7bEvSd6GxHZg96FEHw/XUCXvrsodxv8bqn1VNNQ+q7cJ6IVJijj+r710cD51XRnDZ3+5LEIrN+uFME6Vbqx29b0y/qJhQ9O7cYkWghleiMWpMsglaVEIsauo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nFmbxmKu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nFmbxmKu" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54KDrWxA016026 for ; Tue, 20 May 2025 16:17:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b5DHEtpnOzGMRu3IyuKVwLv2uJQf2egjT6GFT5/7JmE=; b=nFmbxmKuKf0MajPi nbZFKIDahCZZWjKC4o4z+C+7Uwtmbo5b8w03GI+Qci8WtxU3iiW1jVPgVT59J7h6 FWmXZ2yXvrk9ZUn/1klNHUtOQLeT107IQiAunmnZfX/0078ASXFr+kGPLt5kgsUG LrEMTczuuMupPVwEQlxkZopsAdRlPDAFlzqmih3Smh05TVZ9PUBXMRb1lPKQ+/FT wShnPkPJr/vpG5NAmSgoM8P3wU2wsJyuDAHrnXLlESkJ2sX10ejLo86/0D/yYbNz Hr3FSNyz2zqlBiG6Zs8fW8rkoQUpvO89MujXGK37ye+4a1TRwHESZF42HIUQWhEj 23DJ1Q== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46pjnyrc10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 20 May 2025 16:17:25 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6f8b297c78aso11790226d6.0 for ; Tue, 20 May 2025 09:17:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747757844; x=1748362644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b5DHEtpnOzGMRu3IyuKVwLv2uJQf2egjT6GFT5/7JmE=; b=X1UC4sER27johBb0Iyc4h2CiV3ylE1fCTx0DVDyTVY19fcT0DN+JvHDjxPhR8V6HxO HD5WLqyNe/jCzXpqhMudr7NdSQjApruNWz2F34fpuTOZafRmQ24iDC7z9zjkyD5l6/Ml iiliIKnuMMqvKDAB2dLiL3Wy9MW/sA6PG8krYUBszd37fO9oIdjI3Iv1jFM53zkf8ucc zI6arCciTkhOgYYWZyq9OD3GaXyuYX0IrWj/vCN8mgpcks+ZrAmvMY7A9DxbbiXEU7dD Y2tf6ruoMxaI0eGSxGlIEMnmNmEPoRZ/hYetOEctZUzHulX0tQtp89lJV1+C2Ezyw87r p1uA== X-Forwarded-Encrypted: i=1; AJvYcCWI4RiVee4FU2I+JNo3RTMeKiq/3sOPXXlsIWRqgpbuq0pR3QvOGfRWqtgATnISFsgYTixigYsRC2Yy4+4=@vger.kernel.org X-Gm-Message-State: AOJu0YxxQyX6wSy2xExzGa7LutAfqs+31FJDpdjhou/+t2xuO4jRTQDg 9cdwkfYHhC4T/6L9BnAruiQWx+a0Ss9dlwgwBgX/p0ceBjcaLfglUd6icvJ9KqjkScA/5zGtD67 dn/WPJ27iWJ4L54ESoZFjnKacx3r12JzN3HO+icXV8wJoiXL4Zuq2vQGRVELph5NxT7M= X-Gm-Gg: ASbGnct36EOdqYDI96B2ys6w8e5127u/o6iMs5IO6JebMslkeobvqIA6ZgXZwIvh8Ji TyfLGA46WV3NVu2FKCbEmhmS/MDjjQ9cffxLU5GrEDsNxK+vRnSAE+odlDrouLf/7I3ygeoGixk NTATSr2QL6BGMwImDxIEXE8A5jl1Wk4WlwnQX+ZPZYPZV9sDySB+6t+iJY5jMfFLZQXrt2Wni3p Ifl18PRKqYKHXv+Ei1f5UhJaotA6nS/kvOl61oac+isoHB22Z5yhistT8acFC2yPrvR0PrlQKOJ ykoR80HEaZBEq6O+1UimcL4AvEyX5EHhtu85iq9YvvWhWRamAyaNSqByY3x+lM7efw== X-Received: by 2002:a05:6214:c67:b0:6f8:4719:c2 with SMTP id 6a1803df08f44-6f8b096f394mr86190726d6.11.1747757844473; Tue, 20 May 2025 09:17:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5E3avK+19A9Td517SGCLdTYA2yrGFAzKGrj13CJfDGLAXTQvQv4IifqqVvRyOTiit6RWrBw== X-Received: by 2002:a05:6214:c67:b0:6f8:4719:c2 with SMTP id 6a1803df08f44-6f8b096f394mr86190426d6.11.1747757843833; Tue, 20 May 2025 09:17:23 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d4f8e40sm739096966b.183.2025.05.20.09.17.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 09:17:23 -0700 (PDT) Message-ID: <78314d48-4220-4d1a-a168-74268286fa2e@oss.qualcomm.com> Date: Tue, 20 May 2025 18:17:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: qcs9075-rb8: Enable IMX577 camera sensor To: Wenmeng Liu , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vikram Sharma , Loic Poulain , Andi Shyti , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org References: <20250514-rb8_camera-v1-0-bf4a39e304e9@quicinc.com> <20250514-rb8_camera-v1-4-bf4a39e304e9@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250514-rb8_camera-v1-4-bf4a39e304e9@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIwMDEzNCBTYWx0ZWRfXxRRfJLrYtnJj HplfixFELPeoWDBrin12dIxl1LlZQEKgsyWhI22oABiuQF7RGrAM5feH9d33/obAbQ/7wLvveye W9SeY5xYwaslDS2bUvwdNbYQOgvH6ngte3fOOX+V9pnGkRbWLDJWoHJ+ZijphXvHAcNHa1aTICL x8n/uf+hCDIM/AbWDpxb+/nx3l841+6jD+BpJzRkqmWOOu35sJxDKVSPAaFwy/yWddA9hiB1la9 3o1pWut+mwml8KjyeaZ+TzAjfMVq3m9TTse/eL1GTFUAoy0MWOgSw/o5xTKRarxljnAooS0dtl8 jP0miowkfUjJpbkaPbBqXsZ9G4zeIv1G17kkATpLS1gLllJWFiN+UlDwHS8qhHuizOPIBo0F2yO HE7kWVH2m2R9JfMw8LnupUPeu01Hwtn+D+Hoo6u+N8uDKSJI5i4Menj3oCN817P3TTHP08J1 X-Authority-Analysis: v=2.4 cv=Z9XsHGRA c=1 sm=1 tr=0 ts=682cab15 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=COk6AnOGAAAA:8 a=PwJnW-PDuis0shpFSnMA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 9_LPMzHcKk0zJtMIGiEz4ag-Kv9y_Hrp X-Proofpoint-ORIG-GUID: 9_LPMzHcKk0zJtMIGiEz4ag-Kv9y_Hrp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-20_06,2025-05-20_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 mlxlogscore=879 mlxscore=0 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505200134 On 5/14/25 4:40 AM, Wenmeng Liu wrote: > The qcs9075-iq-9075-evk board has 4 camera CSI interfaces. > Enable the third interface with an imx577 sensor for qcs9075-iq-9075-evk. > > An example media-ctl pipeline for the imx577 is: > > media-ctl --reset > media-ctl -V '"imx577 '0-001a'":0[fmt:SRGGB10/4056x3040 field:none]' > media-ctl -V '"msm_csiphy3":0[fmt:SRGGB10/4056x3040]' > media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]' > media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]' > media-ctl -l '"msm_csiphy3":1->"msm_csid0":0[1]' > media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' > > yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 > > Signed-off-by: Wenmeng Liu > --- [...] > +&cci0 { > + status = "disabled"; > + pinctrl-0 = <&cci0_0_default>; > + pinctrl-1 = <&cci0_0_sleep>; > +}; Let's keep them enabled > + > +&cci1 { > + status = "disabled"; > + pinctrl-0 = <&cci1_0_default>; > + pinctrl-1 = <&cci1_0_sleep>; > +}; > + > +&cci2 { > + status = "disabled"; > + pinctrl-0 = <&cci2_0_default>; > + pinctrl-1 = <&cci2_0_sleep>; > +}; > + > +&cci3 { > + status = "okay"; > + pinctrl-0 = <&cci3_0_default>; > + pinctrl-1 = <&cci3_0_sleep>; > +}; the preferred style is: &cci3 { foo = "foo"; bar = "bar"; status = "okay"; }; > + > +&cci3_i2c0 { > + camera@1a { > + compatible = "sony,imx577"; > + reg = <0x1a>; > + > + reset-gpios = <&tlmm 135 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default", "suspend"; > + pinctrl-0 = <&cam3_default>; > + pinctrl-1 = <&cam3_suspend>; property-n property-names please > + > + clocks = <&camcc CAM_CC_MCLK3_CLK>; > + assigned-clocks = <&camcc CAM_CC_MCLK3_CLK>; > + assigned-clock-rates = <24000000>; > + > + dovdd-supply = <&vreg_s4a>; > + avdd-supply = <&vreg_cam3_1p8>; > + /* dvdd-supply = <&vdc_5v>; */ Please either add it or remove the comment [...] > > + cam0_default: cam0-default { > + mclk { > + pins = "gpio72"; > + function = "cam_mclk"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + rst { > + pins = "gpio132"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + }; > + > + cam0_suspend: cam0-suspend { > + mclk { > + pins = "gpio72"; > + function = "cam_mclk"; Don't you want to park the pin to "gpio" in suspend? > + drive-strength = <2>; > + bias-disable; > + }; > + > + rst { > + pins = "gpio132"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > + output-low; The GPIO framework should take care of output Konrad