Re: [PATCH RFC 2/2] cxl/memdev: Remove temporary variables from cxl_memdev_state

Ira Weiny
2025-01-30T15:15:49Z

Jonathan Cameron wrote:
> On Tue, 28 Jan 2025 12:51:08 -0600
> Ira Weiny <ira.weiny@intel.com> wrote:
>
> > As was mentioned by Dan[1] cxl_memdev_state stores values which are only
> > used during device probe. This clutters the data structure and is a
> > hindrance on code maintenance. Those values are best handled with
> > temporary variables.
> >
> > Adjust the query of memory devices to read byte sizes in one call which
> > takes partition information into account. Use the values to create
> > partitions for device state initialization. Take care to separate the
> > mailbox queries from the initialization of device state to steer the
> > mbox code toward taking mailbox objects rather than memdev states.
> > Update spec references while changing these calls.
> Why not jump to 3.2?

<shrug> Just been in the 3.1 spec for so long I forgot.

> >
> > Link: https://lore.kernel.org/all/67871f05cd767_20f32947f@dwillia2-xfh.jf.intel.com.notmuch/ [1]
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Not sure why you had this as an RFC!
> Was it just that we are waiting for v3 from Dan?

Yes. I wanted to get these out there for Alejandro to see the direction
of the dev state call.

>
> If so maybe Dan, just stick these on the back of your series if you are
> happen with these and make Dave's job a tiny bit easier (and so
> rebases happen without needing to sync the two sets).

That is fine with me if Dan has time.

Ira