答复: [PATCH v2] s390: crypto: Use min() instead of doing it manually

[白浩文 <baihaowen@meizu.com>]

hi, Heiko

Thank you for your reply and suggestion.
________________________________________
发件人: Heiko Carstens <hca@linux.ibm.com>
发送时间: 2022年3月15日 17:15:51
收件人: 白浩文
抄送: freude@linux.ibm.com; gor@linux.ibm.com; agordeev@linux.ibm.com; linux-s390@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH v2] s390: crypto: Use min() instead of doing it manually

On Tue, Mar 15, 2022 at 04:01:04PM +0800, Haowen Bai wrote:
> Fix following coccicheck warning:
> drivers/s390/crypto/zcrypt_ep11misc.c:1112:25-26: WARNING opportunity for min()
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/s390/crypto/zcrypt_ep11misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/crypto/zcrypt_ep11misc.c b/drivers/s390/crypto/zcrypt_ep11misc.c
> index 9ce5a71..bb2a527 100644
> --- a/drivers/s390/crypto/zcrypt_ep11misc.c
> +++ b/drivers/s390/crypto/zcrypt_ep11misc.c
> @@ -1109,7 +1109,7 @@ static int ep11_wrapkey(u16 card, u16 domain,
>       if (kb->head.type == TOKTYPE_NON_CCA &&
>           kb->head.version == TOKVER_EP11_AES) {
>               has_header = true;
> -             keysize = kb->head.len < keysize ? kb->head.len : keysize;
> +             keysize = min((size_t)kb->head.len, keysize);

I would assume that checkpatch will now warn that this is an
opportunity to use min_t()...
Anyway, it is up to Harald to decide what do with this.