Re: [PATCH 1/3] crypto: X25519 low-level primitives for ppc64le.

Danny Tsen
2024-05-15T13:00:00Z

Thank you Andy.  Will fix this.

On 5/15/24 3:11 AM, Andy Polyakov wrote:
> Hi,
>
> Couple of remarks inline.
>
>> +# [1] https://www.openssl.org/~appro/cryptogams/
>
> https://github.com/dot-asm/cryptogams/ is arguably better reference.
>
>> +SYM_FUNC_START(x25519_fe51_mul)
>> +.align    5
>
> The goal is to align the label, not the first instruction after the
> directive. It's not a problem in this spot, in the beginning of the
> module that is, but further below it's likely to inject redundant nops
> between the label and meaningful code. But since the directive in
> question is not position-sensitive one can resolve this by changing
> the order of the directive and the SYM_FUNC_START macro.
>
> Cheers.
>