Re: [PATCH 1/3] crypto: X25519 low-level primitives for ppc64le.

Danny Tsen
2024-05-16T11:40:15Z

Hi Andy,

I learned something here.  Will fix this.  Thanks.

-Danny

On 5/16/24 3:38 AM, Andy Polyakov wrote:
> Hi,
>
>>> +.abiversion    2
>>
>> I'd prefer that was left to the compiler flags.
>
> Problem is that it's the compiler that is responsible for providing
> this directive in the intermediate .s prior invoking the assembler.
> And there is no assembler flag to pass through -Wa. If concern is ABI
> neutrality, then solution would rather be #if (_CALL_ELF-0) ==
> 2/#endif. One can also make a case for
>
> #ifdef _CALL_ELF
> .abiversion _CALL_ELF
> #endif
>
> Cheers.
>