public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Zhang Rui <rui.zhang@intel.com>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Subject: [PATCH v1 11/17] thermal: imx: Use the .should_bind() thermal zone callback
Date: Tue, 30 Jul 2024 20:31:07 +0200	[thread overview]
Message-ID: <7860434.lvqk35OSZv@rjwysocki.net> (raw)
In-Reply-To: <1922131.tdWV9SEqCh@rjwysocki.net>

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Make the imx_thermal driver use the .should_bind() thermal zone callback
to provide the thermal core with the information on whether or not to
bind the given cooling device to the given trip point in the given
thermal zone.  If it returns 'true', the thermal core will bind the
cooling device to the trip and the corresponding unbinding will be
taken care of automatically by the core on the removal of the involved
thermal zone or cooling device.

In the imx_thermal case, it only needs to return 'true' for the passive
trip point and it will match any cooling device passed to it, in
analogy with the old-style imx_bind() callback function.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

This patch only depends on patch [09/17].

---
 drivers/thermal/imx_thermal.c |   20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

Index: linux-pm/drivers/thermal/imx_thermal.c
===================================================================
--- linux-pm.orig/drivers/thermal/imx_thermal.c
+++ linux-pm/drivers/thermal/imx_thermal.c
@@ -353,24 +353,16 @@ static int imx_set_trip_temp(struct ther
 	return 0;
 }
 
-static int imx_bind(struct thermal_zone_device *tz,
-		    struct thermal_cooling_device *cdev)
+static bool imx_should_bind(struct thermal_zone_device *tz,
+			    const struct thermal_trip *trip,
+			    struct thermal_cooling_device *cdev,
+			    struct cooling_spec *c)
 {
-	return thermal_zone_bind_cooling_device(tz, IMX_TRIP_PASSIVE, cdev,
-						THERMAL_NO_LIMIT,
-						THERMAL_NO_LIMIT,
-						THERMAL_WEIGHT_DEFAULT);
-}
-
-static int imx_unbind(struct thermal_zone_device *tz,
-		      struct thermal_cooling_device *cdev)
-{
-	return thermal_zone_unbind_cooling_device(tz, IMX_TRIP_PASSIVE, cdev);
+	return trip->type == THERMAL_TRIP_PASSIVE;
 }
 
 static struct thermal_zone_device_ops imx_tz_ops = {
-	.bind = imx_bind,
-	.unbind = imx_unbind,
+	.should_bind = imx_should_bind,
 	.get_temp = imx_get_temp,
 	.change_mode = imx_change_mode,
 	.set_trip_temp = imx_set_trip_temp,




  parent reply	other threads:[~2024-07-30 18:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1922131.tdWV9SEqCh@rjwysocki.net>
2024-07-30 18:16 ` [PATCH v1 17/17] thermal: code: Pass trip descriptors to trip bind/unbind functions Rafael J. Wysocki
2024-07-30 18:19 ` [PATCH v1 01/17] thermal: core: Fold two functions into their respective callers Rafael J. Wysocki
2024-07-30 18:19 ` [PATCH v1 03/17] thermal: core: Drop redundant thermal instance checks Rafael J. Wysocki
2024-07-30 18:20 ` [PATCH v1 04/17] thermal: core: Clean up cdev binding/unbinding functions Rafael J. Wysocki
2024-07-30 18:21 ` [PATCH v1 06/17] thermal: sysfs: Use the dev argument in instance-related show/store Rafael J. Wysocki
2024-07-30 18:21 ` [PATCH v1 07/17] thermal: core: Move thermal zone locking out of bind/unbind functions Rafael J. Wysocki
2024-07-30 18:23 ` [PATCH v1 08/17] thermal: core: Introduce .should_bind() thermal zone callback Rafael J. Wysocki
2024-07-30 18:24 ` [PATCH v1 09/17] thermal: ACPI: Use the " Rafael J. Wysocki
2024-07-30 18:31 ` Rafael J. Wysocki [this message]
2024-07-30 18:33 ` [PATCH v1 12/17] platform/x86: acerhdf: " Rafael J. Wysocki
2024-07-31 20:50   ` Peter Kästle
2024-08-01 10:14     ` Rafael J. Wysocki
2024-08-05 21:51       ` Peter Kästle
2024-08-12 14:56         ` Rafael J. Wysocki
2024-08-12 16:15           ` Rafael J. Wysocki
2024-08-12 18:09             ` Rafael J. Wysocki
2024-07-30 18:34 ` [PATCH v1 13/17] mlxsw: core_thermal: " Rafael J. Wysocki
2024-07-31 12:43   ` Ido Schimmel
2024-07-31 13:01     ` Rafael J. Wysocki
2024-07-31 14:32       ` Rafael J. Wysocki
2024-07-30 18:35 ` [PATCH v1 14/17] thermal/of: " Rafael J. Wysocki
2024-07-30 18:41 ` [PATCH v1 16/17] thermal: code: Clean up trip bind/unbind functions Rafael J. Wysocki
2024-07-30 18:45 ` [PATCH v1 02/17] thermal: core: Rearrange checks in thermal_bind_cdev_to_trip() Rafael J. Wysocki
2024-07-30 18:50 ` [PATCH v1 10/17] thermal: core: Unexport thermal_bind_cdev_to_trip() and thermal_unbind_cdev_from_trip() Rafael J. Wysocki
2024-07-30 18:53 ` [PATCH v1 15/17] thermal: core: Drop unused bind/unbind functions and callbacks Rafael J. Wysocki
2024-07-30 18:56 ` [PATCH v1 05/17] thermal: core: Move lists of thermal instances to trip descriptors Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7860434.lvqk35OSZv@rjwysocki.net \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox