From: Dmitry Osipenko <digetx@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Jeff Brasen <jbrasen@nvidia.com>
Subject: Re: [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver
Date: Tue, 21 Jan 2020 19:37:57 +0300 [thread overview]
Message-ID: <788ba1e1-0b00-ee89-dd65-56aba7cb3f19@gmail.com> (raw)
In-Reply-To: <f02faa4c-5838-15d2-1b76-75c17fcc0d9d@gmail.com>
21.01.2020 19:31, Dmitry Osipenko пишет:
> Hello Jon,
>
> 20.01.2020 19:01, Jon Hunter пишет:
>
> [snip]
>
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + if (!res)
>> + return -ENODEV;
>> +
>> + port->membase = devm_ioremap(&pdev->dev, res->start,
>> + resource_size(res));
>
> devm_platform_ioremap_resource()
>
>> + if (!port->membase)
>> + return -ENOMEM;
>> +
>> + port->mapbase = res->start;
>> + port->mapsize = resource_size(res);
>> +
>> + uart->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
>
> Why reset is shared? It shall not be shared at least on T20/30/124/210..
>
> [snip]
>
Actually, looks like use of a shared reset for a not-really-shared reset
should be fine.
next prev parent reply other threads:[~2020-01-21 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 16:01 [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver Jon Hunter
2020-01-21 15:41 ` Greg Kroah-Hartman
2020-01-21 15:46 ` Jon Hunter
2020-01-21 16:31 ` Dmitry Osipenko
2020-01-21 16:37 ` Dmitry Osipenko [this message]
2020-01-21 18:34 ` Jon Hunter
2020-01-21 18:46 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=788ba1e1-0b00-ee89-dd65-56aba7cb3f19@gmail.com \
--to=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrasen@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox