From: David Howells <dhowells@redhat.com>
To: paulmck@linux.vnet.ibm.com
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, eric.dumazet@gmail.com, jslaby@suse.cz,
jmorris@namei.org
Subject: Re: [PATCH RFC] pid: make setpgid() system call use RCU read-side critical section
Date: Tue, 31 Aug 2010 14:02:31 +0100 [thread overview]
Message-ID: <7899.1283259751@redhat.com> (raw)
In-Reply-To: <20100830172631.GA11868@linux.vnet.ibm.com>
Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> write_lock_irq(&tasklist_lock);
>
> err = -ESRCH;
> + rcu_read_lock();
> ...
> + rcu_read_unlock();
> write_unlock_irq(&tasklist_lock);
I would generally put the rcu lock outside the IRQ disabled section on the
basis that it's better to keep the amount of time we have interrupts disabled
shortest.
> Located-by: Andrew Morton <akpm@linux-foundation.org>
'Reported-by' might be more consistent with what others use.
David
next prev parent reply other threads:[~2010-08-31 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 17:26 [PATCH RFC] pid: make setpgid() system call use RCU read-side critical section Paul E. McKenney
2010-08-30 19:51 ` Jiri Slaby
2010-08-30 20:32 ` Paul E. McKenney
2010-09-09 22:15 ` Oleg Nesterov
2010-09-16 9:18 ` Jiri Slaby
2010-09-16 16:39 ` Oleg Nesterov
2010-08-31 13:02 ` David Howells [this message]
2010-08-31 15:12 ` Paul E. McKenney
2010-08-31 15:31 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7899.1283259751@redhat.com \
--to=dhowells@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=josh@joshtriplett.org \
--cc=jslaby@suse.cz \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox