From: Stephen Boyd <sboyd@kernel.org>
To: Conor Dooley <conor@kernel.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Michael Turquette <mturquette@baylibre.com>,
Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: Hal Feng <hal.feng@starfivetech.com>,
linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org <linux-clk@vger.kernel.org>
Subject: RE: [PATCH v7 1/2] clk: starfive: jh7110-sys: Add notifier for PLL0 clock
Date: Thu, 29 Aug 2024 12:24:25 -0700 [thread overview]
Message-ID: <78b5aa6efc5b3ca4151f503367a9bd3a.sboyd@kernel.org> (raw)
In-Reply-To: <NTZPR01MB0956E46297168E8E21D6F17F9F962@NTZPR01MB0956.CHNPR01.prod.partner.outlook.cn>
Quoting Xingyu Wu (2024-08-28 22:42:43)
> On 29/08/2024 04:19, Stephen Boyd wrote:
> >
> > Quoting Xingyu Wu (2024-08-26 01:04:29)
> > > Add notifier function for PLL0 clock. In the function, the cpu_root
> > > clock should be operated by saving its current parent and setting a
> > > new safe parent (osc clock) before setting the PLL0 clock rate. After
> > > setting PLL0 rate, it should be switched back to the original parent clock.
> > >
> > > Fixes: e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling for JH7110
> > > SoC")
> > > Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> > > Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> > > ---
> >
> > What is the urgency of this patch? I can't tell from the commit text, so I'm
> > assuming it can bake in clk-next for a few weeks.
>
> Hi Stephen,
>
> This is urgent. Without this patch, Cpufreq does not work and the CPU can't work in the best frequency of 1.5GHz. This patch can improve the performance of the visionfive-2 board.
>
Ok. I'll apply it to clk-fixes then.
next prev parent reply other threads:[~2024-08-29 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 8:04 [PATCH v7 0/2] Add notifier for PLL0 clock and set it 1.5GHz on the JH7110 SoC Xingyu Wu
2024-08-26 8:04 ` [PATCH v7 1/2] clk: starfive: jh7110-sys: Add notifier for PLL0 clock Xingyu Wu
2024-08-27 5:49 ` Hal Feng
2024-08-28 20:19 ` Stephen Boyd
2024-08-29 5:42 ` Xingyu Wu
2024-08-29 19:24 ` Stephen Boyd [this message]
2024-08-29 18:12 ` Michael Jeanson
2024-08-26 8:04 ` [PATCH v7 2/2] riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz Xingyu Wu
2024-08-27 5:52 ` Hal Feng
2024-09-09 14:28 ` [PATCH v7 0/2] Add notifier for PLL0 clock and set it 1.5GHz on the JH7110 SoC Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78b5aa6efc5b3ca4151f503367a9bd3a.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=conor@kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox